Skip to content

Do we need a RestTemplate bean? #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dsyer opened this issue Mar 31, 2016 · 2 comments
Closed

Do we need a RestTemplate bean? #239

dsyer opened this issue Mar 31, 2016 · 2 comments
Milestone
1.0.0.RC2

Comments

@dsyer
Copy link
Contributor

dsyer commented Mar 31, 2016

Currently TraceWebClientAutoConfiguration creates a @Bean of type RestTemplate. I'd prefer it if that was up to the user really, but I guess before I remove it I thought I'd better ask.
@dsyer dsyer added this to the 1.0.0.RC2 milestone Mar 31, 2016
@marcingrzejszczak
Copy link
Contributor

Yup makes sense to remove it if the user doesn't want it

@marcingrzejszczak
Copy link
Contributor

...Then we shouldn't be adding it

@dsyer dsyer closed this as completed in 00b67a8 Mar 31, 2016
shivangshah pushed a commit to shivangshah/spring-cloud-sleuth that referenced this issue Apr 1, 2016
Remove @bean RestTemplate
c37d4c9 
(If users need one they can add it themselves)

Fixes spring-cloudgh-239
shivangshah pushed a commit to shivangshah/spring-cloud-sleuth that referenced this issue Apr 1, 2016
Remove @bean RestTemplate
c8a4732 
(If users need one they can add it themselves)

Fixes spring-cloudgh-239
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0.RC2
Development

No branches or pull requests
2 participants
@dsyer @marcingrzejszczak