Skip to content

Remove docker from zipkin examples, and instead use java -jar #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
codefromthecrypt opened this issue Mar 28, 2016 · 0 comments · Fixed by #234
Closed

Remove docker from zipkin examples, and instead use java -jar #230

codefromthecrypt opened this issue Mar 28, 2016 · 0 comments · Fixed by #234
Assignees

Comments

@codefromthecrypt
Copy link
Contributor

Before, docker was helpful as zipkin had 3 processes, whereas now zipkin has only one: zipkin-server. Since zipkin-server is a spring boot application, it should be familiar to have folks start it directly.

The hope is that by removing docker from examples, people can focus on the actual integration of note, and maintainers can be more productive by answering less questions.

marcingrzejszczak added a commit that referenced this issue Mar 29, 2016
@marcingrzejszczak marcingrzejszczak self-assigned this Mar 29, 2016
marcingrzejszczak added a commit that referenced this issue Apr 1, 2016
marcingrzejszczak added a commit that referenced this issue Apr 4, 2016
marcingrzejszczak added a commit that referenced this issue Apr 4, 2016
Removed docker compose and updated README

fixes #230
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants