Switches ID encoding to fixed-length (#450)

Before, we were using variable encoding for trace and span identifiers.
This complicates search for those who are copy/pasting fixed-length IDs
provisioned upstream. This moves to standard formatting, while
maintaining tolerant reads.

The code added will also be used to support 128-bit (32 char) trace IDs.

Fixes #449

Author: adriancole

spring-cloud-sleuth-core/src/main/java/org/springframework/cloud/sleuth/Span.java

@@ -453,12 +453,34 @@ public boolean isExportable() {
 	}
 
 	/**
-	 * Represents given long id as hex string
+	 * Represents given long id as 16-character lower-hex string
 	 */
 	public static String idToHex(long id) {
-		return Long.toHexString(id);
+		char[] data = new char[16];
+		writeHexLong(data, 0, id);
+		return new String(data);
 	}
 
+	/** Inspired by {@code okio.Buffer.writeLong} */
+	static void writeHexLong(char[] data, int pos, long v) {
+		writeHexByte(data, pos + 0,  (byte) ((v >>> 56L) & 0xff));
+		writeHexByte(data, pos + 2,  (byte) ((v >>> 48L) & 0xff));
+		writeHexByte(data, pos + 4,  (byte) ((v >>> 40L) & 0xff));
+		writeHexByte(data, pos + 6,  (byte) ((v >>> 32L) & 0xff));
+		writeHexByte(data, pos + 8,  (byte) ((v >>> 24L) & 0xff));
+		writeHexByte(data, pos + 10, (byte) ((v >>> 16L) & 0xff));
+		writeHexByte(data, pos + 12, (byte) ((v >>> 8L) & 0xff));
+		writeHexByte(data, pos + 14, (byte)  (v & 0xff));
+	}
+
+	static void writeHexByte(char[] data, int pos, byte b) {
+		data[pos + 0] = HEX_DIGITS[(b >> 4) & 0xf];
+		data[pos + 1] = HEX_DIGITS[b & 0xf];
+	}
+
+	static final char[] HEX_DIGITS =
+			{'0', '1', '2', '3', '4', '5', '6', '7', '8', '9', 'a', 'b', 'c', 'd', 'e', 'f'};
+
 	/**
 	 * Parses a 1 to 32 character lower-hex string with no prefix into an unsigned long, tossing any
 	 * bits higher than 64.

spring-cloud-sleuth-core/src/test/java/org/springframework/cloud/sleuth/SpanTests.java

@@ -36,12 +36,12 @@
 public class SpanTests {
 
 	@Test
-	public void should_convert_long_to_hex_string() throws Exception {
+	public void should_convert_long_to_16_character_hex_string() throws Exception {
 		long someLong = 123123L;
 
 		String hexString = Span.idToHex(someLong);
 
-		then(hexString).isEqualTo("1e0f3");
+		then(hexString).isEqualTo("000000000001e0f3");
 	}
 
 	@Test

spring-cloud-sleuth-core/src/test/java/org/springframework/cloud/sleuth/instrument/zuul/ApacheHttpClientRibbonRequestCustomizerTests.java

@@ -65,9 +65,9 @@ public void should_set_tracing_headers_on_the_context_when_there_is_a_span() thr
 		this.customizer.inject(this.span, this.customizer.toSpanTextMap(requestBuilder));
 
 		HttpUriRequest request = requestBuilder.build();
-		thenThereIsAHeaderWithNameAndValue(request, Span.SPAN_ID_NAME, "1");
-		thenThereIsAHeaderWithNameAndValue(request, Span.TRACE_ID_NAME, "2");
-		thenThereIsAHeaderWithNameAndValue(request, Span.PARENT_ID_NAME, "3");
+		thenThereIsAHeaderWithNameAndValue(request, Span.SPAN_ID_NAME, "0000000000000001");
+		thenThereIsAHeaderWithNameAndValue(request, Span.TRACE_ID_NAME, "0000000000000002");
+		thenThereIsAHeaderWithNameAndValue(request, Span.PARENT_ID_NAME, "0000000000000003");
 		thenThereIsAHeaderWithNameAndValue(request, Span.PROCESS_ID_NAME, "processId");
 	}
 

spring-cloud-sleuth-core/src/test/java/org/springframework/cloud/sleuth/instrument/zuul/OkHttpClientRibbonRequestCustomizerTests.java

@@ -62,9 +62,9 @@ public void should_set_tracing_headers_on_the_context_when_there_is_a_span() thr
 		this.customizer.inject(this.span, this.customizer.toSpanTextMap(requestBuilder));
 
 		Request request = requestBuilder.build();
-		thenThereIsAHeaderWithNameAndValue(request, Span.SPAN_ID_NAME, "1");
-		thenThereIsAHeaderWithNameAndValue(request, Span.TRACE_ID_NAME, "2");
-		thenThereIsAHeaderWithNameAndValue(request, Span.PARENT_ID_NAME, "3");
+		thenThereIsAHeaderWithNameAndValue(request, Span.SPAN_ID_NAME, "0000000000000001");
+		thenThereIsAHeaderWithNameAndValue(request, Span.TRACE_ID_NAME, "0000000000000002");
+		thenThereIsAHeaderWithNameAndValue(request, Span.PARENT_ID_NAME, "0000000000000003");
 		thenThereIsAHeaderWithNameAndValue(request, Span.PROCESS_ID_NAME, "processId");
 	}
 

spring-cloud-sleuth-core/src/test/java/org/springframework/cloud/sleuth/instrument/zuul/RestClientRibbonRequestCustomizerTests.java

@@ -62,9 +62,9 @@ public void should_set_tracing_headers_on_the_context_when_there_is_a_span() thr
 		this.customizer.inject(this.span, this.customizer.toSpanTextMap(requestBuilder));
 
 		HttpRequest request = requestBuilder.build();
-		thenThereIsAHeaderWithNameAndValue(request, Span.SPAN_ID_NAME, "1");
-		thenThereIsAHeaderWithNameAndValue(request, Span.TRACE_ID_NAME, "2");
-		thenThereIsAHeaderWithNameAndValue(request, Span.PARENT_ID_NAME, "3");
+		thenThereIsAHeaderWithNameAndValue(request, Span.SPAN_ID_NAME, "0000000000000001");
+		thenThereIsAHeaderWithNameAndValue(request, Span.TRACE_ID_NAME, "0000000000000002");
+		thenThereIsAHeaderWithNameAndValue(request, Span.PARENT_ID_NAME, "0000000000000003");
 		thenThereIsAHeaderWithNameAndValue(request, Span.PROCESS_ID_NAME, "processId");
 	}