Skip to content

Clean up (old) images in assets folder #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ghillert opened this issue Jul 24, 2019 · 2 comments
Closed

Clean up (old) images in assets folder #1248

ghillert opened this issue Jul 24, 2019 · 2 comments
Assignees
@oodamien
Labels
type/technical-debt Techical Dept
Milestone
Iteration 152 -> ...

Comments

@ghillert
Copy link
Contributor

Also, should images that will be hashed and included in the root dist folder exist in the asset folder (duplicated files in distribution) or moved to different folder?

Take a look at the following last 2 comments:

angular/angular-cli#4212

We should also revisit some images referenced in templates - they are not hashed and could cause caching issues.
@oodamien oodamien self-assigned this Jul 29, 2019
@oodamien oodamien removed their assignment Aug 7, 2019
@sabbyanandan sabbyanandan added the type/technical-debt Techical Dept label Aug 12, 2019
@sabbyanandan
Copy link
Contributor

We are adding unused images to the shipped binary, which we can avoid.

oodamien added a commit to oodamien/spring-cloud-dataflow-ui that referenced this issue Aug 15, 2019
@oodamien
Clean unused images
fa3d058 
Part of spring-cloud#1248
@oodamien oodamien mentioned this issue Aug 15, 2019
Closed
oodamien added a commit to oodamien/spring-cloud-dataflow-ui that referenced this issue Aug 15, 2019
@oodamien
Clean unused images
1068815 
Part of spring-cloud#1248
ilayaperumalg pushed a commit that referenced this issue Aug 22, 2019
@oodamien @ilayaperumalg
Clean unused images
1254e46 
Part of #1248

Remove images from SCSS

2 images import in base64
@sabbyanandan
Copy link
Contributor

Addressed in 1254e46.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oodamien oodamien

Labels
type/technical-debt Techical Dept
Projects
None yet
Milestone
Iteration 152 -> SCDF 2.3.0.M1
Development

Successfully merging a pull request may close this issue.

Clean unused images, update SCSS path images oodamien/spring-cloud-dataflow-ui
3 participants
@oodamien @ghillert @sabbyanandan