This repository was archived by the owner on Jan 19, 2022. It is now read-only.
Add new parameter-store module and starter #682
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddumelendez
added
component: parameter-store
maciejwalkowiak
approved these changes
Sep 22, 2020
eddumelendez
force-pushed
the
parameterstore_module
branch
from
6336dff to
39bea17
Compare
eddumelendez
commented
Sep 23, 2020
|
|
||
| ConfigurableEnvironment env = (ConfigurableEnvironment) environment; | ||
|
|
||
| String appName = getName(); |
There was a problem hiding this comment.
it should be moved to ParameterStoreProperties
|
|
||
| private String name; | ||
|
|
||
| private String prefix = "/config"; |
There was a problem hiding this comment.
should not have default value. The default one is set in the autoconfigure module
|
|
||
| private String prefix = "/config"; | ||
|
|
||
| private String defaultContext = "application"; |
There was a problem hiding this comment.
should not have default value. The default one is set in the autoconfigure module
|
Perhaps we can wait with this one for 2.4 |
This commit introduces the following changes: * Deprecate `spring-cloud-aws-parameter-store-config` module * Deperecate `spring-cloud-starter-aws-parameter-store-config` module * Create `spring-cloud-aws-parameter-store` * Create `spring-cloud-starter-aws-parameter-store` New module is not aware of spring boot and the starter has not classes.
eddumelendez
force-pushed
the
parameterstore_module
branch
from
8946db9 to
ed79bfe
Compare
github-actions
bot
added
type: dependency-upgrade
|
I will close this until figure it out #607 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces the following changes:
spring-cloud-aws-parameter-store-configmodulespring-cloud-starter-aws-parameter-store-configmodulespring-cloud-aws-parameter-storespring-cloud-starter-aws-parameter-storeNew module is not aware of spring boot and the starter has not classes.