This repository was archived by the owner on Jan 19, 2022. It is now read-only.
Fix duplicate error logging #465
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AbstractMethodMessageHandler always logs an exception when there is no handler method for a particular exception and the SimpleMessageListenerContainer logs the same exception again when the message deletion policy is ON_SUCCESS. This results in duplicated error logging. This commit fixes this issue by delegating exception processing to AbstractMethodMessageHandler only when there is a configured handler. Fixes: gh-394
spring-projects-issues
added
the
status: waiting-for-triage
maciejwalkowiak
added
component: sqs
|
Thanks @sayembd for contribution. With this change in place, when deletion policy is different than |
maciejwalkowiak
added
status: waiting-for-feedback
maciejwalkowiak
added a commit
that referenced
this pull request
Jun 3, 2020
…istener. This commit fixes this issue by delegating exception processing to AbstractMethodMessageHandler only when there is a configured handler. If there is none, exception is logged. Fixes gh-394 Closes gh-465 Co-authored-by: Maciej Walkowiak <[email protected]>
tmnuwan12
pushed a commit
to tmnuwan12/spring-cloud-aws
that referenced
this pull request
Jun 7, 2020
…istener. This commit fixes this issue by delegating exception processing to AbstractMethodMessageHandler only when there is a configured handler. If there is none, exception is logged. Fixes spring-atticgh-394 Closes spring-atticgh-465 Co-authored-by: Maciej Walkowiak <[email protected]>
maciejwalkowiak
added a commit
to maciejwalkowiak/spring-cloud-aws
that referenced
this pull request
Oct 15, 2020
…istener. This commit fixes this issue by delegating exception processing to AbstractMethodMessageHandler only when there is a configured handler. If there is none, exception is logged. Fixes spring-atticgh-394 Closes spring-atticgh-465 Co-authored-by: Maciej Walkowiak <[email protected]>
maciejwalkowiak
added a commit
to maciejwalkowiak/spring-cloud-aws
that referenced
this pull request
Oct 15, 2020
…istener. This commit fixes this issue by delegating exception processing to AbstractMethodMessageHandler only when there is a configured handler. If there is none, exception is logged. Fixes spring-atticgh-394 Closes spring-atticgh-465 Co-authored-by: Maciej Walkowiak <[email protected]>
maciejwalkowiak
added a commit
to maciejwalkowiak/spring-cloud-aws
that referenced
this pull request
Oct 15, 2020
…istener. This commit fixes this issue by delegating exception processing to AbstractMethodMessageHandler only when there is a configured handler. If there is none, exception is logged. Fixes spring-attic#394 Closes spring-attic#465 Co-authored-by: Maciej Walkowiak <[email protected]>
maciejwalkowiak
added a commit
to maciejwalkowiak/spring-cloud-aws
that referenced
this pull request
Oct 15, 2020
…istener. This commit fixes this issue by delegating exception processing to AbstractMethodMessageHandler only when there is a configured handler. If there is none, exception is logged. Fixes spring-attic#394 Closes spring-attic#465 Co-authored-by: Maciej Walkowiak <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the processing of an exception thrown by a queue message handler method, the AbstractMethodMessageHandler always logs the error when there is no existing handler method for that exception. On the other hand, the SimpleMessageListenerContainer logs the same exception again when the message deletion policy is set to ON_SUCCESS. This results in duplicated error logging.
This commit fixes this issue by delegating exception processing to AbstractMethodMessageHandler only when there is a configured exception handler.