Skip to content
This repository was archived by the owner on Jan 19, 2022. It is now read-only.

nit: Typo #519

Closed
econn9 opened this issue Jan 6, 2020 · 6 comments
Closed

nit: Typo #519

econn9 opened this issue Jan 6, 2020 · 6 comments
Assignees
Labels
Milestone

Comments

@econn9
Copy link

econn9 commented Jan 6, 2020

Describe the bug
incorrectly spelled word in Sysout output

throw new Exception("Couldn't stop container withing 15 seconds");

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 6, 2020
@maciejwalkowiak maciejwalkowiak added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels May 29, 2020
@maciejwalkowiak maciejwalkowiak added this to the 2.2.3 milestone May 29, 2020
@tmnuwan12
Copy link
Contributor

How do we take on fixing bugs. Some one get assigned to work on it..?

@maciejwalkowiak
Copy link
Contributor

I'll go through all the issues again in upcoming day(s) and mark ones that can be picked up with "help wanted". There is also some contributor guidelines needed as not everything is obvious - like for example not breaking backward compatibility for 2.2.x branch. If you would like to fix this one it would be great 👍

@tmnuwan12
Copy link
Contributor

Yes I will fix this one. Waiting for further instruction from @maciejwalkowiak

@maciejwalkowiak
Copy link
Contributor

@tmnuwan12 I went through issues. Check ones with "help wanted" label: https://github.com/spring-cloud/spring-cloud-aws/issues?q=is%3Aopen+is%3Aissue+label%3A%22help+wanted%22

@tmnuwan12
Copy link
Contributor

@maciejwalkowiak is there any ci pipeline I can use to test my changes or we have to use our aws credentials when running integration tests..?

@maciejwalkowiak
Copy link
Contributor

Once you create pull request there will be a build executed against your branch. It won't execute tests connecting to AWS though. I think there is a space for improvement there but I'm not sure yet how to tackle it.

tmnuwan12 added a commit to tmnuwan12/spring-cloud-aws that referenced this issue May 31, 2020
maciejwalkowiak pushed a commit that referenced this issue May 31, 2020
tmnuwan12 added a commit to tmnuwan12/spring-cloud-aws that referenced this issue Jun 7, 2020
maciejwalkowiak pushed a commit to maciejwalkowiak/spring-cloud-aws that referenced this issue Oct 15, 2020
maciejwalkowiak pushed a commit to maciejwalkowiak/spring-cloud-aws that referenced this issue Oct 15, 2020
maciejwalkowiak pushed a commit to maciejwalkowiak/spring-cloud-aws that referenced this issue Oct 15, 2020
maciejwalkowiak pushed a commit to maciejwalkowiak/spring-cloud-aws that referenced this issue Oct 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging a pull request may close this issue.

4 participants