Skip to content
This repository was archived by the owner on Jan 19, 2022. It is now read-only.

AWS SDK version upgrade request #482

Closed
internetstaff opened this issue Jul 23, 2019 · 14 comments
Closed

AWS SDK version upgrade request #482

internetstaff opened this issue Jul 23, 2019 · 14 comments
Assignees
Labels
status: in-progress An issue that being worked on type: dependency-upgrade A dependency upgrade
Milestone

Comments

@internetstaff
Copy link

1.11.415 is now pretty stale - we're having to override lots of dependencies for newer functionality.

Any chance of an upgrade? :)

Thanks!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 23, 2019
@geriBatai
Copy link

Are there any plans for this? Current SDK is even more outdated now, blocking some developments, especially in Cloud Native space.

@dkimdon
Copy link

dkimdon commented Feb 24, 2020

We want to use the new framework for per-pod IAM permissions in Kubernetes as described here:

https://aws.amazon.com/blogs/opensource/introducing-fine-grained-iam-roles-service-accounts/

The current AWS SDK version (1.11.415) doesn't support the sts:AssumeRoleWithWebIdentity call necessary for permission control as described above. Updating to a version equal to or greater than 1.11.623 will fix this for us. See details at the link above.

I can rebuilt the spring-cloud-aws code with the new version in spring-cloud-aws-dependencies/pom.xml. I ran the local tests with the new version (I didn't run the tests that actually use AWS) and they all passed. I don't want to build my own jar but would rather use an untouched jar from upstream.

Thanks a lot for considering :-)

-David

@internetstaff
Copy link
Author

@dkimdon Perhaps try submitting a pull request, even as tiny as it probably is? :)

@ryanjbaxter @OlgaMaciaszek @marcingrzejszczak You're the only recent committers on spring-cloud-aws ... are you by chance able to assist ... or is this project dead? :)

@kingofmooks
Copy link

@dkimdon any chance you could post the pom your using to manually get this to work. i cant get this one to work for me.

@internetstaff
Copy link
Author

@spencergibb Your blog post on 17 April seems to confirm that this project is dead, as already indicated by the plethora of "waiting-for-triage" issues and pull requests. Can you clarify?

Thanks.

@spencergibb spencergibb linked a pull request May 18, 2020 that will close this issue
19 tasks
@spencergibb
Copy link
Contributor

Look for some official communication soon.

@joodlehammond
Copy link

Hi @spencergibb can this upgrade not be released separately from the SDK 2.0 work? It looks like @dkimdon managed to get this repo to work with the latest AWS SDK 1.0 libraries. Why does this need to bundled in with the new major update?

@spencergibb
Copy link
Contributor

Updating to the latest 1.x doesn't have to happen on a major. PRs welcome

@jonfreedman
Copy link

"soon" is a bit vague - should we look to remove this as a dependency?

@internetstaff
Copy link
Author

@spencergibb it doesn't seem like other PRs are being reviewed. There's a significant amount of overhead (especially w.r.t. integration tests) for a non-contributor to perform this upgrade. Are there no contributors that could knock this one out?

Alternatively, is there a CI pipeline for this project that will at least run the integration tests?

Thanks.

@spencergibb
Copy link
Contributor

Please see #557 for updates on the state of the project.

@maciejwalkowiak
Copy link
Contributor

Dependencies will be updated independently from AWS SDK v2 migration. At the time being if you're using Maven you can overwrite versions by adding AWS SDK v1 BOM to your dependencies management - you only have to make sure that it's declared first, before Spring Cloud Dependencies BOM.

<dependencyManagement>
	<dependencies>
		<dependency>
			<groupId>com.amazonaws</groupId>
			<artifactId>aws-java-sdk-bom</artifactId>
			<version>1.11.791</version>
			<type>pom</type>
			<scope>import</scope>
		</dependency>
		<dependency>
			<groupId>org.springframework.cloud</groupId>
			<artifactId>spring-cloud-dependencies</artifactId>
			<version>${spring-cloud.version}</version>
			<type>pom</type>
			<scope>import</scope>
		</dependency>
	</dependencies>
</dependencyManagement>

@maciejwalkowiak maciejwalkowiak added this to the 2.2.3 milestone May 29, 2020
@maciejwalkowiak maciejwalkowiak added type: dependency-upgrade A dependency upgrade and removed status: waiting-for-triage An issue we've not yet triaged labels May 29, 2020
@maciejwalkowiak maciejwalkowiak self-assigned this May 31, 2020
@maciejwalkowiak maciejwalkowiak added the status: in-progress An issue that being worked on label May 31, 2020
tmnuwan12 pushed a commit to tmnuwan12/spring-cloud-aws that referenced this issue Jun 7, 2020
maciejwalkowiak added a commit to maciejwalkowiak/spring-cloud-aws that referenced this issue Oct 15, 2020
maciejwalkowiak added a commit to maciejwalkowiak/spring-cloud-aws that referenced this issue Oct 15, 2020
maciejwalkowiak added a commit to maciejwalkowiak/spring-cloud-aws that referenced this issue Oct 15, 2020
maciejwalkowiak added a commit to maciejwalkowiak/spring-cloud-aws that referenced this issue Oct 15, 2020
@gauravbrills
Copy link

rsions by adding AWS SDK v1 BOM to your dependencies management - you only have to make sure that it's declared first, before Spring Cloud Dependencies BOM.

how about for gradle will this work

 mavenBom "com.amazonaws:aws-java-sdk-bom:${awsVersion}"
         mavenBom "org.springframework.cloud:spring-cloud-dependencies:${springCloudVersion}"

@maciejwalkowiak
Copy link
Contributor

@gauravbrills I don't know how boms work with Gradle.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: in-progress An issue that being worked on type: dependency-upgrade A dependency upgrade
Development

Successfully merging a pull request may close this issue.

10 participants