Ability to get s3:// URI back from an S3 resource

[osi]

I am trying to "round-trip" resources from a s3:// URI into a Resource and back again. Currently, SimpleStorageResource#getURL returns a https:// URI into AWS.

It would be nice to be able to round-trip these URIs

[tmnuwan12]

I want to help. Where should I look into.?

[maciejwalkowiak]

@tmnuwan12 go for it. Just keep in mind that whatever we do here should stay backward compatible.

[tmnuwan12]

Can you assign it to me.. But I need some time with this if that's ok. I have some office stuff to clear out this week.

[tmnuwan12]

For bug fixes do we need to branch off from master or 2.2.x branch..?

[maciejwalkowiak]

Good question! Ideally from 2.2.x

[tmnuwan12]

I checked the code for SimpleStorageResource. From what I understand from the requirement is ability to specify "s3://" endpoint when creating SimpleStorageResource and return
"s3://" compliant URL by calling method getURL().. Before I change anything want to check the approach here.. I was thinking of add/modify constructor to accommodate a URL object or url string and return a compatible URL based on constructor argument.. Feel free to provide some inputs please.

[tmnuwan12]

@maciejwalkowiak

[maciejwalkowiak]

I think it it should be possible to obtain s3:// and https:// no matter how what parameters were passed to the constructor. What do you think?

[osi]

agreed @maciejwalkowiak

[tmnuwan12]

@osi @maciejwalkowiak Yes I agree. What do you think about adding getURI() implementation for SimpleStorageResource class that provides the "s3://" URI.

[tmnuwan12]

@maciejwalkowiak I am getting some compilation errors when running maven tests ( but in Intellij editor no compilation errors). Is this something known issue or am I missing something..?

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0:testCompile (default-testCompile) on project spring-cloud-aws-core: Compilation failure: Compilation failure:
[21,17] package org.junit does not exist

Also I am getting a warning in the build logs as below not sure anything related.

[WARNING] Could not transfer metadata org.springframework.boot:spring-boot-dependencies:2.4.0-SNAPSHOT/maven-metadata.xml from/to apache.snapshots (https://repository.apache.org/snapshots): peer not authenticated

[maciejwalkowiak]

@tmnuwan12 I explained reasons for compilation failure here #565 (review). Lets continue discussion in the pull request.