Merge pull request #696 from knarewski/add-support-for-redis-client

Add support for redis-client, which does not automatically cast types to strings

Author: andrehjr

lib/split/alternative.rb

@@ -166,7 +166,7 @@ def validate!
     end
 
     def reset
-      Split.redis.hmset key, "participant_count", 0, "completed_count", 0, "recorded_info", nil
+      Split.redis.hmset key, "participant_count", 0, "completed_count", 0, "recorded_info", ""
       unless goals.empty?
         goals.each do |g|
           field = "completed_count:#{g}"

lib/split/experiment.rb

@@ -85,7 +85,7 @@ def save
         persist_experiment_configuration
       end
 
-      redis.hmset(experiment_config_key, :resettable, resettable,
+      redis.hmset(experiment_config_key, :resettable, resettable.to_s,
                                          :algorithm, algorithm.to_s)
       self
     end
@@ -408,12 +408,12 @@ def cohorting_disabled?
 
     def disable_cohorting
       @cohorting_disabled = true
-      redis.hset(experiment_config_key, :cohorting, true)
+      redis.hset(experiment_config_key, :cohorting, true.to_s)
     end
 
     def enable_cohorting
       @cohorting_disabled = false
-      redis.hset(experiment_config_key, :cohorting, false)
+      redis.hset(experiment_config_key, :cohorting, false.to_s)
     end
 
     protected

spec/experiment_spec.rb

@@ -68,7 +68,7 @@ def alternative(color)
       experiment_start_time = Time.parse("Sat Mar 03 14:01:03")
       expect(Time).to receive(:now).twice.and_return(experiment_start_time)
       experiment.save
-      Split.redis.hset(:experiment_start_times, experiment.name, experiment_start_time)
+      Split.redis.hset(:experiment_start_times, experiment.name, experiment_start_time.to_s)
 
       expect(Split::ExperimentCatalog.find("basket_text").start_time).to eq(experiment_start_time)
     end