Merge pull request #568 from giraffate/force_alternative_with_version

Fix `force_aleternative` for experiments with incremented version

Author: andrehjr

lib/split/dashboard.rb

@@ -33,9 +33,10 @@ class Dashboard < Sinatra::Base
     end
 
     post '/force_alternative' do
-      alternative = Split::Alternative.new(params[:alternative], params[:experiment])
+      experiment = Split::ExperimentCatalog.find(params[:experiment])
+      alternative = Split::Alternative.new(params[:alternative], experiment.name)
       alternative.increment_participation
-      Split::User.new(self)[params[:experiment]] = params[:alternative]
+      Split::User.new(self)[experiment.key] = alternative.name
       redirect url('/')
     end
 

spec/dashboard_spec.rb

@@ -74,19 +74,39 @@ def link(color)
   end
 
   describe "force alternative" do
-    let!(:user) do
-      Split::User.new(@app, { experiment.name => 'red' })
-    end
+    context "initial version" do
+      let!(:user) do
+        Split::User.new(@app, { experiment.name => 'red' })
+      end
 
-    before do
-      allow(Split::User).to receive(:new).and_return(user)
+      before do
+        allow(Split::User).to receive(:new).and_return(user)
+      end
+
+      it "should set current user's alternative" do
+        blue_link.participant_count = 7
+        post "/force_alternative?experiment=#{experiment.name}", alternative: "blue"
+        expect(user[experiment.key]).to eq("blue")
+        expect(blue_link.participant_count).to eq(8)
+      end
     end
 
-    it "should set current user's alternative" do
-      blue_link.participant_count = 7
-      post "/force_alternative?experiment=#{experiment.name}", alternative: "blue"
-      expect(user[experiment.name]).to eq("blue")
-      expect(blue_link.participant_count).to eq(8)
+    context "incremented version" do
+      let!(:user) do
+        experiment.increment_version
+        Split::User.new(@app, { "#{experiment.name}:#{experiment.version}" => 'red' })
+      end
+
+      before do
+        allow(Split::User).to receive(:new).and_return(user)
+      end
+
+      it "should set current user's alternative" do
+        blue_link.participant_count = 7
+        post "/force_alternative?experiment=#{experiment.name}", alternative: "blue"
+        expect(user[experiment.key]).to eq("blue")
+        expect(blue_link.participant_count).to eq(8)
+      end
     end
   end