Skip to content

Commit 525347f

Browse files
committed
2 more lyft issues
Signed-off-by: Gary O'Neall <[email protected]>
1 parent c8343ae commit 525347f

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

src/main/java/org/spdx/library/model/ExternalDocumentRef.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ public String getSpdxDocumentNamespace() throws InvalidSPDXAnalysisException {
187187
return "";
188188
}
189189
if (docNamespace.get() instanceof IndividualUriValue) {
190-
String docUri = ((IndividualUriValue)(docNamespace.get())).getIndividualURI();
190+
String docUri = ((IndividualUriValue)docNamespace.get()).getIndividualURI();
191191
if (Objects.isNull(docUri)) {
192192
logger.warn("Missing individual URI in doc namespace");
193193
return "";
@@ -306,7 +306,6 @@ protected List<String> _verify(List<String> verifiedIds, String specVersion) {
306306
*/
307307
@Override
308308
public int compareTo(ExternalDocumentRef o) {
309-
int retval = 0;
310309
String myDocumentNamespace;
311310
try {
312311
myDocumentNamespace = getSpdxDocumentNamespace();
@@ -321,7 +320,7 @@ public int compareTo(ExternalDocumentRef o) {
321320
logger.warn("Error getting compare document namepsace",e);
322321
compareDocumentNamespace = "";
323322
}
324-
retval = myDocumentNamespace.compareTo(compareDocumentNamespace);
323+
int retval = myDocumentNamespace.compareTo(compareDocumentNamespace);
325324
if (retval != 0) {
326325
return retval;
327326
}

0 commit comments

Comments
 (0)