Don't add blank comments to created relationships

goneall · goneall · commit 17347022e086 · 2022-06-24T10:28:52.000-07:00
This messes up compares.

Signed-off-by: Gary O'Neall &lt;gary@sourceauditor.com&gt;
diff --git a/src/main/java/org/spdx/library/model/RelatedElementCollection.java b/src/main/java/org/spdx/library/model/RelatedElementCollection.java
@@ -170,7 +170,7 @@ public boolean add(SpdxElement e) {
 			return false;
 		}
 		try {
-			Relationship relationship = owningElement.createRelationship(e, relationshipTypeFilter, "");
+			Relationship relationship = owningElement.createRelationship(e, relationshipTypeFilter, null);
 			return owningElement.addRelationship(relationship);
 		} catch (InvalidSPDXAnalysisException e1) {
 			logger.error("Error adding relationship",e1);

Original file line number	Diff line number	Diff line change
`@@ -170,7 +170,7 @@ public boolean add(SpdxElement e) {`
`170`	`170`	`return false;`
`171`	`171`	`}`
`172`	`172`	`try {`
`173`		`- Relationship relationship = owningElement.createRelationship(e, relationshipTypeFilter, "");`
	`173`	`+ Relationship relationship = owningElement.createRelationship(e, relationshipTypeFilter, null);`
`174`	`174`	`return owningElement.addRelationship(relationship);`
`175`	`175`	`} catch (InvalidSPDXAnalysisException e1) {`
`176`	`176`	`logger.error("Error adding relationship",e1);`