Skip to content

Add maxWait to begin functions #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 9, 2021
Merged

Add maxWait to begin functions #89

merged 2 commits into from
Dec 9, 2021

Conversation

nseidle
Copy link
Member

@nseidle nseidle commented Dec 8, 2021

Passes maxWait into begin function. This is helpful for systems that fail to respond. The default 1100ms really equals 3.3s when isConnected fails multiple times. This allows user to override as needed.

@PaulZC PaulZC changed the base branch from main to release_candidate December 9, 2021 11:49
@PaulZC PaulZC merged commit 67fe9db into release_candidate Dec 9, 2021
@PaulZC PaulZC deleted the maxWaitBegin branch December 9, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants