Make processRTCMframe weak #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow processRTCMframe to be overridden. Its replacement would now be able to place all of the bytes into a buffer for processing at a later time and eliminate a deep call stack for every byte.
|
Hi Lee (@LeeLeahy2 ), Many thanks for the update. It's failing on ESP32 (v2.0.4)... "error: value computed is not used" on |
|
Hi Lee (@LeeLeahy2 ), Please pull release_candidate and give it a quick test. If you're happy, we can get this merged and up-issued. Thanks! |
|
Hi Paul, This looks good. Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow processRTCMframe to be overridden. Its replacement would now be
able to place all of the bytes into a buffer for processing at a later
time and eliminate a deep call stack for every byte.