Skip to content

Add EOE and TIMEUTC messaging and some minor fixes. #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 2, 2022

Conversation

rislec
Copy link

@rislec rislec commented Jul 1, 2022

No description provided.

@rislec rislec changed the title Minor fixes. Add EOE and TIMEUTC messaging and some minor fixes. Jul 1, 2022
@PaulZC
Copy link
Collaborator

PaulZC commented Jul 2, 2022

Hi @rislec ,

Great contribution - thank you!

Going forward, I only want to use the "Ptr" version of the callbacks. It was a mistake to pass the complete struct to the callback - it can cause stack problems on some platforms. I'm keeping the existing non-Ptr callbacks for backward-compatibility only. So I will delete setAutoNAVTIMEUTCcallback and setAutoEOEcallback.

Next time, please remember to update keywords.txt and - if possible - include a new example too.

Thanks again,
Paul

@PaulZC PaulZC changed the base branch from main to release_candidate July 2, 2022 10:30
@PaulZC PaulZC merged commit 5f30c48 into sparkfun:release_candidate Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants