You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I know that I did not follow all of the processes in Adding_New_Messages.md and CONTRIBUTING.md, but as with #78, this is as far as I'm going with this for now. May come back at a later date to do other required pieces.
I have realized after opening this that SFE_UBLOX_GNSS::process() will need a decent amount of work to fully support PUBX messages. I am going to go a different direction, but some may find simply being able to enable the messages using enumerated/mnemonic values to be useful, so will leave this open.
Hi Thomas (@nabelekt ),
Thanks for submitting this PR too!
I am not going to merge it completely, but I will merge the PUBX message definitions. There is no need to add enable/disablePUBXMessage - they are redundant. You can simply call configureMessage instead.
For auto support of PUBX, it might be best to follow the approach I used for GPGGA and GNGGA and provide the PUBX messages via callbacks? Or provide a new processPUBX which is equivalent to processNMEA? I really do not want to include any form of NMEA / PUBX parsing in this library.
Best wishes,
Paul
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know that I did not follow all of the processes in Adding_New_Messages.md and CONTRIBUTING.md, but as with #78, this is as far as I'm going with this for now. May come back at a later date to do other required pieces.