Skip to content

Missing return value in SerLCD::write() #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gvansickle opened this issue Mar 21, 2020 · 3 comments
Closed

Missing return value in SerLCD::write() #3

gvansickle opened this issue Mar 21, 2020 · 3 comments

Comments

@gvansickle
Copy link

Note the missing return on SerLCD::write(), which should return a size_t but returns nothing:

@fourstix
Copy link

Hi, Good catch. It's an error in the original code that Sparkfun harvested.
It should end with "return 1;" since one byte was written.

@fourstix
Copy link

fourstix commented Mar 23, 2020

I have submitted a pull request with a fix. Thanks for raising this issue. If you want the fixed code now, it's available in the fourstix/QwiicSerLCD repository code.

nseidle added a commit that referenced this issue Mar 23, 2020
Fix for Issue #3 Missing return value in SerLCD::write()
@nseidle
Copy link
Member

nseidle commented Mar 23, 2020

Thanks all! Will be rolled into next release.

@nseidle nseidle closed this as completed Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants