forked from fourstix/QwiicSerLCD
-
Notifications
You must be signed in to change notification settings - Fork 11
Missing return value in SerLCD::write() #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi, Good catch. It's an error in the original code that Sparkfun harvested. |
I have submitted a pull request with a fix. Thanks for raising this issue. If you want the fixed code now, it's available in the fourstix/QwiicSerLCD repository code. |
nseidle
added a commit
that referenced
this issue
Mar 23, 2020
Fix for Issue #3 Missing return value in SerLCD::write()
Thanks all! Will be rolled into next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Note the missing return on SerLCD::write(), which should return a size_t but returns nothing:
SparkFun_SerLCD_Arduino_Library/src/SerLCD.cpp
Line 395 in 34d4f1d
The text was updated successfully, but these errors were encountered: