Skip to content

Failure in Wifi Config when using base coordinates saved in SD in GGG MM SS.ssss format #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amlago opened this issue May 23, 2024 · 9 comments

Comments

@amlago
Copy link

amlago commented May 23, 2024

Failure in Wifi Config when using base coordinates saved in SD in GGG MM SS.ssss format

When trying to add coordinates previously saved in the base coordinates file in GGG MM SS.sssss format, they are copied to the boxes incorrectly.
The Facet detects the spaces between GGG and MM and SS.ssss and copies the degrees in latitude, the minutes in longitude and thus fills in boxes.
I am on version 3.8, which is the one that works best for me in my activity, where I almost always use the base Facet.

@amlago
Copy link
Author

amlago commented May 23, 2024

This started a long time ago with entry #428.

@PaulZC
Copy link
Contributor

PaulZC commented Jun 5, 2024

Hi Angel (@amlago ),

Thank you for reporting this issue.

The root cause of this is loadGeodetic in main.js ( link ). It uses split to split the station coordinates into parts. The problem is that this was written for the DD.ddddd format, and fails badly with the DD MM SS.sss format. The extra spaces cause the latitude MM to be treated as longitude.

I will work on a fix for this.

Best wishes,
Paul

PaulZC added a commit that referenced this issue Jun 5, 2024
@PaulZC
Copy link
Contributor

PaulZC commented Jun 6, 2024

This has been corrected - in commit 1675bb4

There will be a RC binary available for test in 1-2 days

@PaulZC
Copy link
Contributor

PaulZC commented Jun 6, 2024

Also related:

DD-MM-SS.ssss was being mistaken as DD-MM-SS by coordinateIdentifyInputType. This led to rounding errors after the base coordinates had been saved / entered.

Resolved in commit 3cf5141

@amlago
Copy link
Author

amlago commented Jun 6, 2024

excellent. I'm waiting for the RC and I'll try it.
Greetings

@PaulZC
Copy link
Contributor

PaulZC commented Jun 13, 2024

Hi Angel (@amlago ),

Please try the latest Release Candidate firmware:

https://github.com/sparkfun/SparkFun_RTK_Firmware_Binaries/blob/main/RTK_Surveyor_Firmware_RC-Jun_10_2024.bin

Please let us know if this resolves your issue.

Very best wishes,
Paul

@amlago
Copy link
Author

amlago commented Jun 13, 2024

I will try it and make the corresponding comments.
My greetings
Angel

@amlago
Copy link
Author

amlago commented Jun 13, 2024

Entering coordinates in other formats seems to work fine. I will inform you of any details if necessary.
Thank you

@nseidle
Copy link
Member

nseidle commented Jul 22, 2024

Fixed in v4.1.

@nseidle nseidle closed this as completed Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants