Skip to content

line too small in NVM.ino loadSystemSettingsFromFileSD #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
PaulZC opened this issue Sep 8, 2023 · 1 comment
Closed

line too small in NVM.ino loadSystemSettingsFromFileSD #645

PaulZC opened this issue Sep 8, 2023 · 1 comment
Labels
In Release Candidate

Comments

@PaulZC
Copy link
Contributor

PaulZC commented Sep 8, 2023 •
edited
Loading

I noticed Settings line 61 too long errors after manually entering a PP device profile token.

This line of code defines line to be 60 characters. But the line containing the pointPerfectDeviceProfileToken can be 68 characters - excluding the terminator. The 60 needs to be increased to (at least) 70. 100 might be a better choice to match parseLine.

Ditto for this line
nseidle added a commit that referenced this issue Sep 27, 2023
@nseidle
Increase max length of NVM setting
a151261 
Fix for #645
@nseidle nseidle mentioned this issue Sep 27, 2023
Merged
@nseidle
Copy link
Member

nseidle commented Sep 28, 2023

This has been fixed in v3.9.

@nseidle nseidle closed this as completed Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
In Release Candidate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nseidle @PaulZC