Skip to content

Add extra flags to enable build caching #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

marsfan
Copy link

@marsfan marsfan commented Jan 5, 2021

See #296 for some discussion of the issue.

See sparkfun#296 for some discussion of the issue.
@Wenn0101
Copy link
Contributor

@marsfan thank you for the PR! After you submitted this PR I re-evaluated the flags that are being used in our build. (I have been meaning to do this for a little while to reduce some of the less useful warnings during building).

When we build the mbed static library, it outputs some flags for use in our build. We created a process were we can ignore some of these flags, before storing them for use in the build. That is where the flags in -iprefix{runtime.platform.path}/cores/ @{build.variant.path}/mbed/.c-flags come from. -MMD was previously on this list of excluded flags. I removed it from the list of excluded flags to achieve the same result in this PR.

This is all a long winded way of saying that I liked your contribution, but I wanted to achieve it in a different way.
I want to make sure you get credit for this contribution, I'll see if I can figure out how to do that.
I am closing this PR in favor of the other one linked above.

@Wenn0101 Wenn0101 closed this Jan 21, 2021
@marsfan
Copy link
Author

marsfan commented Jan 21, 2021

@Wenn0101 Great! As long as it caches the build files I'm happy.

@Wenn0101
Copy link
Contributor

@marsfan thanks for the contribution. This change is live in the v2.0.4 release that went live today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants