Improve analogWrite #153
Merged
Improve analogWrite #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
April 8, 2020 11:27
I think these were pre-development for the Apollo3 Plus
this includes several commented-out sections for modules that do not have corresponding definitions for the Apollo3. Reached out to Arpit at Ambiq Micro to address this
The full duplex direction enumeration was removed in SDK 2.4.2. Need to find out if this functionality is still supported or not.
The support is good enough to not warrant such strongly worded advice
this ensures that (when the timer is running) at least one pulse is emitted at each desired setting this removes concerns about calling analogWrite too often and changing the duty cycle the tradeoff is that analogWrite is now a blocking function that could take up to one whole timer period
Closed
|
Fixes #146 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ap3-pwm_outputand consequently analogWrite now properly clear and reset the ctimer peripherals when changing the desired configuration. The functions may be called as often as desired without affecting the PWM duty cycle thanks to a simplified rollover check.