fix: update menu usage (#78)

- Adds comments to clarify how multiple menus could be used
- Removes unused items variable from menu include
- Changes Timber Menu argument to use correct menu

Author: rise-erpelding

src/php/functions.php

@@ -73,7 +73,7 @@
  * @return array
  */
 function add_to_context( $context ) {
-	$context['menu'] = new \Timber\Menu( 'primary-menu' );
+	$context['menu'] = new \Timber\Menu( 'primary' );
 	$context['footer_sidebar'] = Timber\Timber::get_widgets( 'footer-area' );
 	return $context;
 }

src/php/inc/theme-setup.php

@@ -34,7 +34,12 @@ function sparkpress_theme_setup() {
 		 */
 		add_theme_support( 'post-thumbnails' );
 
-		register_nav_menus( array( 'primary' => 'Primary' ) );
+		register_nav_menus(
+			array(
+				'primary' => 'Primary',
+				// register additional menus
+			)
+		);
 
 		/*
 		 * Switch default core markup for search form, comment form, and comments

src/php/views/header.twig

@@ -22,7 +22,7 @@
 							<a href="{{ site.url }}" class="cmp-main-nav__home-link" rel=" home">{{ site.name }}</a>
 						</div>
 						<nav class="cmp-main-nav__menu" aria-label="Main">
-							{% include "menu.twig" with {'items': menu.get_items} %}
+							{% include "menu.twig" %}
 						</nav>
 					</div>
 				{% endblock %}

src/php/views/menu.twig

@@ -1,3 +1,4 @@
+{# can specify menu when including template #}
 {% if menu %}
 	<ul class="cmp-main-nav__list">
 		{% for item in menu.items %}