Skip to content

Commit c55c5bc

Browse files
fix: update menu usage (#78)
- Adds comments to clarify how multiple menus could be used - Removes unused items variable from menu include - Changes Timber Menu argument to use correct menu
1 parent 43639f8 commit c55c5bc

File tree

4 files changed

+9
-3
lines changed

4 files changed

+9
-3
lines changed

src/php/functions.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@
7373
* @return array
7474
*/
7575
function add_to_context( $context ) {
76-
$context['menu'] = new \Timber\Menu( 'primary-menu' );
76+
$context['menu'] = new \Timber\Menu( 'primary' );
7777
$context['footer_sidebar'] = Timber\Timber::get_widgets( 'footer-area' );
7878
return $context;
7979
}

src/php/inc/theme-setup.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,12 @@ function sparkpress_theme_setup() {
3434
*/
3535
add_theme_support( 'post-thumbnails' );
3636

37-
register_nav_menus( array( 'primary' => 'Primary' ) );
37+
register_nav_menus(
38+
array(
39+
'primary' => 'Primary',
40+
// register additional menus
41+
)
42+
);
3843

3944
/*
4045
* Switch default core markup for search form, comment form, and comments

src/php/views/header.twig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
<a href="{{ site.url }}" class="cmp-main-nav__home-link" rel=" home">{{ site.name }}</a>
2323
</div>
2424
<nav class="cmp-main-nav__menu" aria-label="Main">
25-
{% include "menu.twig" with {'items': menu.get_items} %}
25+
{% include "menu.twig" %}
2626
</nav>
2727
</div>
2828
{% endblock %}

src/php/views/menu.twig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
{# can specify menu when including template #}
12
{% if menu %}
23
<ul class="cmp-main-nav__list">
34
{% for item in menu.items %}

0 commit comments

Comments
 (0)