Disconnect on handling frames from unknown streams

Signed-off-by: Eloi DEMOLIS <[email protected]>

Author: Wonshtrum

lib/src/protocol/mux/converter.rs

@@ -1,5 +1,3 @@
-use std::str::from_utf8_unchecked;
-
 use kawa::{
     AsBuffer, Block, BlockConverter, Chunk, Flags, Kawa, Pair, ParsingErrorKind, ParsingPhase,
     StatusLine, Store,
@@ -107,7 +105,6 @@ impl<'a, T: AsBuffer> BlockConverter<T> for H2BlockConverter<'a> {
                         || compare_no_case(key, b"transfer-encoding")
                         || compare_no_case(key, b"upgrade")
                     {
-                        println!("Elided H2 header: {}", unsafe { from_utf8_unchecked(key) });
                         return true;
                     }
                 }

lib/src/protocol/mux/h2.rs

@@ -739,8 +739,12 @@ impl<Front: SocketHandler> ConnectionH2<Front> {
         match frame {
             Frame::Data(data) => {
                 let mut slice = data.payload;
-                // can this fail?
-                let global_stream_id = *self.streams.get(&data.stream_id).unwrap();
+                // can this fail? yes
+                let Some(global_stream_id) = self.streams.get(&data.stream_id).copied() else {
+                    error!("Handling Data frame with no attached stream {:#?}", self);
+                    incr!("h2.data_no_stream.error");
+                    return self.force_disconnect();
+                };
                 let stream = &mut context.streams[global_stream_id];
                 let parts = stream.split(&self.position);
                 let kawa = parts.rbuffer;
@@ -778,7 +782,11 @@ impl<Front: SocketHandler> ConnectionH2<Front> {
                 }
                 // can this fail?
                 let stream_id = headers.stream_id;
-                let global_stream_id = *self.streams.get(&stream_id).unwrap();
+                let Some(global_stream_id) = self.streams.get(&stream_id).copied() else {
+                    error!("Handling Headers frame with no attached stream {:#?}", self);
+                    incr!("h2.headers_no_stream.error");
+                    return self.force_disconnect();
+                };
 
                 if let Some(priority) = &headers.priority {
                     if self.prioriser.push_priority(stream_id, priority.clone()) {

lib/src/protocol/mux/pkawa.rs

@@ -103,9 +103,6 @@ where
                         }
                     } else if compare_no_case(&k, b"priority") {
                         // todo!("decode priority");
-                        warn!("DECODE PRIORITY: {}", unsafe {
-                            std::str::from_utf8_unchecked(v.as_ref())
-                        });
                         prioriser.push_priority(
                             stream_id,
                             PriorityPart::Rfc9218 {