Skip to content

Fix: allow multiple users/databases in postgresql_access resources #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2023
Merged

Fix: allow multiple users/databases in postgresql_access resources #751

merged 1 commit into from
Jul 7, 2023

Conversation

@schrd
Copy link
Contributor

@schrd schrd commented Jul 7, 2023

Description

PostgreSQL pg_hba.conf allows to specify multiple databases and users in one entry. They are seperated by comma. This fixes the regex which parses pg_hba.conf entries to match multiple databases or users in one entry.

Issues Resolved

closes #750

Check List

  • A summary of changes made is included in the CHANGELOG under ## Unreleased
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

@schrd schrd requested a review from a team as a code owner July 7, 2023 09:57
xorima
xorima previously approved these changes Jul 7, 2023
View reviewed changes
@xorima xorima added the Release: Patch Release to Chef Supermarket as a version patch when merged label Jul 7, 2023
bmhughes
bmhughes requested changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@bmhughes bmhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this has broken testing even though from a quick check of the docs this is the correct format for multiple databases @schrd.
If you can take a look at that we can get this merged.

@bmhughes
Copy link
Contributor

bmhughes commented Jul 7, 2023

When I rewrote this to use a regex to parse pg_hba I had a bad feeling we'd now have two problems 😂

Fix: allow multiple users/databases in postgresql_access resources
635fb50 
PostgreSQL pg_hba.conf allows to specify multiple databases and users in
one entry. They are seperated by comma.
@schrd schrd force-pushed the 750-access-multiple-users-databases branch from d7478eb to 635fb50 Compare July 7, 2023 12:15
@schrd
Copy link
Contributor Author

schrd commented Jul 7, 2023

Looks like this has broken testing even though from a quick check of the docs this is the correct format for multiple databases @schrd. If you can take a look at that we can get this merged.

@bmhughes test error should be fixed now

@bmhughes
Copy link
Contributor

bmhughes commented Jul 7, 2023

LGTM, thanks!

@bmhughes bmhughes added Release: Minor Release to Chef Supermarket as a minor release when merged and removed Release: Patch Release to Chef Supermarket as a version patch when merged labels Jul 7, 2023
@bmhughes bmhughes merged commit e9012eb into sous-chefs:main Jul 7, 2023
@kitchen-porter
Copy link
Contributor

kitchen-porter commented Jul 7, 2023

Released as: 11.6.0

@kitchen-porter kitchen-porter mentioned this pull request Oct 16, 2025
Merged
@kitchen-porter kitchen-porter mentioned this pull request Nov 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmhughes bmhughes bmhughes approved these changes

@xorima xorima xorima left review comments

Assignees

No one assigned

Labels

Release: Minor Release to Chef Supermarket as a minor release when merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

postgresql_access Resource fails when multiple databases or users are specified

4 participants

@schrd @bmhughes @kitchen-porter @xorima