Fix NoMethodError in pg_ident parsing for non-matching lines

Co-authored-by: ramereth <[email protected]>
Signed-off-by: Dan Webb <[email protected]>

Author: 2 people

.markdownlint-cli2.yaml

@@ -7,3 +7,4 @@ config:
     maximum: 2
 ignores:
   - .github/copilot-instructions.md
+  - .windsurf/**

libraries/ident.rb

@@ -77,7 +77,7 @@ def initialize
           end
 
           def add(entry)
-            raise unless entry.is_a?(PgIdentFileEntry)
+            raise ArgumentError, "Expected PgIdentFileEntry, got #{entry.class}" unless entry.is_a?(PgIdentFileEntry)
 
             return false if include?(entry)
 
@@ -107,11 +107,11 @@ def entry(map_name, system_username = nil, database_username = nil)
           end
 
           def entry?(map_name)
-            !@entries.none? { |e| e.map_name.eql?(map_name) }
+            @entries.any? { |e| e.map_name.eql?(map_name) }
           end
 
           def include?(entry)
-            raise unless entry.is_a?(PgIdentFileEntry)
+            raise ArgumentError, "Expected PgIdentFileEntry, got #{entry.class}" unless entry.is_a?(PgIdentFileEntry)
 
             @entries.any? { |e| e.eql?(entry) }
           end
@@ -131,7 +131,7 @@ def read!(file = 'pg_ident.conf', sort: true)
           end
 
           def remove(entry)
-            raise unless entry.is_a?(PgIdentFileEntry) || entry.is_a?(String)
+            raise ArgumentError, "Expected PgIdentFileEntry or String, got #{entry.class}" unless entry.is_a?(PgIdentFileEntry) || entry.is_a?(String)
 
             case entry
             when PgIdentFileEntry
@@ -191,8 +191,9 @@ class PgIdentFileEntry
             comment: 0,
           }.freeze
           ENTRY_FIELDS = ENTRY_FIELD_FORMAT.keys.dup.freeze
+          COMPOSITE_KEY_FIELDS = %i(map_name system_username database_username).freeze
 
-          private_constant :ENTRY_FIELD_FORMAT, :ENTRY_FIELDS
+          private_constant :ENTRY_FIELD_FORMAT, :ENTRY_FIELDS, :COMPOSITE_KEY_FIELDS
 
           def initialize(map_name:, system_username:, database_username:, comment: nil)
             @map_name = map_name
@@ -215,9 +216,7 @@ def to_s
           def eql?(other)
             return false unless self.class.eql?(other.class)
 
-            return true if %i(map_name system_username database_username).all? { |field| send(field).eql?(entry.send(field)) }
-
-            false
+            COMPOSITE_KEY_FIELDS.all? { |field| send(field).eql?(other.send(field)) }
           end
 
           def update(system_username:, database_username:, comment:)

spec/libraries/ident_spec.rb

@@ -183,4 +183,4 @@
       expect(entry1.eql?(entry3)).to be_falsy
     end
   end
-end
+end