Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

dev/launch.sh breaks if you haven't run "yarn" yet #1914

Closed
ggilmore opened this issue Jan 15, 2019 · 4 comments
Closed

dev/launch.sh breaks if you haven't run "yarn" yet #1914

ggilmore opened this issue Jan 15, 2019 · 4 comments
Assignees
Labels
bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. ops & tools & dev
Milestone

Comments

@ggilmore
Copy link
Contributor

https://sourcegraph.slack.com/archives/C07KZF47K/p1547578053302000?thread_ts=1547577858.301500&cid=C07KZF47K

@ggilmore ggilmore added bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. ops & tools & dev labels Jan 15, 2019
@ggilmore ggilmore added this to the 3.0 milestone Jan 15, 2019
@keegancsmith
Copy link
Member

https://github.com/sourcegraph/sourcegraph/pull/1496#issuecomment-452663654

Alternatively we can revert that PR and do "go run" where minversion checks that output of runtime.Version()

@nicksnyder
Copy link
Contributor

I like the go run idea.

@nicksnyder nicksnyder assigned attfarhan and unassigned nicksnyder Jan 17, 2019
@attfarhan
Copy link
Contributor

attfarhan commented Jan 17, 2019

Do we expect that some of our contributors (or teammates) use development builds of Go? It seems like there are a lot of complaints about runtime.Version()'s output being unhelpful for this kind of use (golang/go#21207, golang/go#11972, golang/go#11972). I think it's possible to parse release tags well enough, but development builds might be tricky.

@nicksnyder
Copy link
Contributor

I don't think anyone uses a development build of go so I wouldn't worry about that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug An error, flaw or fault that produces an incorrect or unexpected result, or behavior. ops & tools & dev
Projects
None yet
Development

No branches or pull requests

4 participants