patch: Fixed a bug where file diffs for renamed files were not picked up #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise LGTM |
|
Thanks, will follow-up with a test. |
gbbr
force-pushed
the
tmpl-debt
branch
2 times, most recently
from
fafdd52 to
d635afe
Compare
dmitshur
changed the title
renames with similarity index 100%.
|
If this works and is ready to merge, perhaps it's better to do than, rather than not merging at all? Given that it fixes a real issue. Tests can be added later as an enhancement. |
beyang
added a commit
that referenced
this pull request
Feb 23, 2016
patch: Fixed a bug where file diffs for renamed files were not picked up
dmitshur
added a commit
that referenced
this pull request
Feb 23, 2016
Followup for #9 (comment). This test passes now, but would fail before #9 was merged.
Created tests for this in #12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File diffs containing only renames are ignored.