Skip to content

latest tagged image is not the latest image #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ssddanbrown opened this issue Jul 4, 2023 · 4 comments
Closed

latest tagged image is not the latest image #410

ssddanbrown opened this issue Jul 4, 2023 · 4 comments

Comments

@ssddanbrown
Copy link
Contributor

Sorry if this is a known part of your own process, but I noticed that latest is currently pointing to the 23.6 version of the image whereas users might expect this to point to 23.6.0-1.
Just raising after getting confused helping a user deal with the SAML config issue you fixed yesterday, while having their container updated to use the latest image.

If it's a real edge-case pain to tag your own patched updates with latest, then I respect that and am planning a BookStack patch release in the next day or two which I'd assume would help get things aligned again anyway.

@rjhenry
Copy link
Collaborator

rjhenry commented Jul 4, 2023

Thanks for pointing it out @ssddanbrown - I hadn't noticed (as I use tagged releases only) and hadn't looked too closely at the Actions workflow that updates the latest tag. Without digging in too deeply, I suspect it's an artifact of using SemVer's pre-release indicator to manage the build-of-the-Docker-project.
I'll look into whether there's a better way of managing releases and/or version numbers later.

@sebzan
Copy link

sebzan commented Jul 4, 2023

@rjhenry: Hope you guys take care of this small matter quickly so it will work smooth again for us portainer users (who are not so hardcore in linux/docker). :)

@rjhenry
Copy link
Collaborator

rjhenry commented Jul 4, 2023

I've tweaked the workflow to auto-tag latest on all release builds. It's not perfect, but as long as Bookstack is being developed and changes aren't being backported I can see no glaring issues.

@rjhenry rjhenry closed this as completed Jul 4, 2023
@ssddanbrown
Copy link
Contributor Author

Thanks again for your fast efforts @rjhenry!

but as long as Bookstack is being developed and changes aren't being backported I can see no glaring issues

Yeah, I have no plans on supporting multiple streams of BookStack. The slowly evolving single linear upgrade path has worked well so far and I have no reason to change.
If that was to change I'd probably provide notice to downstream projects anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants