Skip to content

Remove in-container .env file in favour of container runtime environment settings #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rjhenry opened this issue Jul 3, 2023 · 2 comments
Assignees

Comments

@rjhenry
Copy link
Collaborator

rjhenry commented Jul 3, 2023

As noted in this comment and again here, setting values in the in-container .env file has caused and is likely to cause additional headaches.

Remove the part of the entrypoint script that sets up the .env file and provide documentation on how to migrate if needed.

@rjhenry rjhenry self-assigned this Jul 3, 2023
@rjhenry
Copy link
Collaborator Author

rjhenry commented Jul 5, 2023

This is being addressed in #409.

@stavros-k
Copy link

This can be closed now I guess!
Thanks for the work!
Going to try this tomorrow!

@rjhenry rjhenry closed this as completed Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants