Adapter should not use typeof
#3795
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure why `typeof` was used but Adapter is a class and does not need a typeof. The problem is that it was not possible to have a function thats return type is an Adapter:
```
const createAdapter = (): Adapter => { ... };
server.adapter(createAdapter());
```
|
This PR might be wrong from me. But I create an issue and hope for an answer from the maintainer(s) #3796 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why
typeofwas used but Adapter is a class and does not need a typeof. The problem is that it was not possible to have a function thats return type is an Adapter:If there is a reason for use of
typeofthen the types should beAdapter | typeof AdapterThe kind of change this PR does introduce
Current behavior
New behavior
Other information (e.g. related issues)