Skip to content

Add friendlyErrorHadler cleanup to prevent memory leak #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2023
Merged

Add friendlyErrorHadler cleanup to prevent memory leak #490

merged 1 commit into from
Apr 13, 2023

Conversation

@carera
Copy link
Contributor

@carera carera commented Mar 3, 2023

registerFriendlyErrorHandler method adds a listener on pub and sub client. Let's remove it in close()

@darrachequesne darrachequesne merged commit b5da02d into socketio:main Apr 13, 2023
@darrachequesne
Copy link
Member

darrachequesne commented Apr 13, 2023

@carera good catch, thanks!

@carera
Copy link
Contributor Author

carera commented Apr 13, 2023

Hi @darrachequesne
Thanks for merging, I was hoping we could somehow add tests for this but i'm not sure how? Would you be able to assist?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@carera @darrachequesne @jminarik-atl