TypeError: this.subClient.psubscribe is not a function

[aekryz1993]

pubClient.duplicate() return object with a property function named pSubscribe (S is uppercase). and at /node_modules/@socket.io/redis-adapter/dist/index.js the property is named psubscribe (S is lowercase).

For now, The issue is fixed by adding property psubscribe (S is lowercase):

const { Server } = require("socket.io");
const { createAdapter } = require("@socket.io/redis-adapter");
const { createClient } = require("redis");

const io = new Server();

const pubClient = createClient({ host: "localhost", port: 6379 });

const subClient = pubClient.duplicate();
subClient.psubscribe = subClient.pSubscribe

Versions:

"redis": "^4.0.0-rc.1",
"@socket.io/redis-adapter": "^7.0.0",

The error was:

error: TypeError: this.subClient.psubscribe is not a function
          at new RedisAdapter (/node_modules/@socket.io/redis-adapter/dist/index.js:64:24)
          at new OurOwnRedisAdapter (/lib/websocket-adapter.js:39:5)
          at Namespace._initAdapter (/node_modules/socket.io/dist/namespace.js:40:24)
          at Server.adapter (/node_modules/socket.io/dist/index.js:133:17)
          at module.exports (/lib/websocket.js:27:6)
          at Server.<anonymous> (/server.js:25:16)
          at Object.onceWrapper (events.js:421:28)
          at Server.emit (events.js:315:20)
          at emitListeningNT (net.js:1352:10)
          at processTicksAndRejections (internal/process/task_queues.js:79:21)

[darrachequesne]

Hi! I guess we could replace psubscribe by PSUBSCRIBE, but I wasn't able to find the way to pub/sub a buffer:

const { createClient } = require("redis");

(async () => {
  const client = createClient();
  await client.connect();

  const subscriber = client.duplicate();
  await subscriber.connect();

  await subscriber.subscribe("channel", (message, channel) => {
    console.log(message, channel);
  });

  client.publish("channel", "test"); // prints "test channel"
  client.publish("channel", Buffer.from([1,2,3])); // prints "��� channel" (buffer as string)

})();

The return_buffers option of v3 does not seem to be supported anymore. Does anyone have a clue?

[darrachequesne]

An issue was opened here: redis/node-redis#1718

Note: we could also use base64 encoding, but it would be a backward incompatible change

[NarHakobyan]

Hi guys, as I see node-redis has merged the PR, so do you have plans to release a new version?

[darrachequesne]

I'm working on this.

[NarHakobyan]

@darrachequesne thank you 🙏

[darrachequesne]

Support for redis@4 was added in release 7.1.0: https://github.com/socketio/socket.io-redis-adapter/releases/tag/7.1.0

[djaffer]

Please in the documentation add connect if it is explicitly required or the package doing when the client is passed.

[yanush]

you added support for redis (v4) and broke the support for ioredis
"clientSub.PSUBSCRIBE is not a function" at new RedisAdapter (..../node_modules/@socket.io/redis-adapter/dist/index.js:76:24)
7.0.1 doesn't have that issue

[darrachequesne]

@yanush that's weird, I was not able to reproduce, and it seems there is no PSUBSCRIBE (all uppercase) command in the codebase. Could you please check?

[yanush]

@darrachequesne I think you are right. It might be some patched code I tried to fix the node-redis v4 support.
Sorry for the hassle.
Thanks!

[darrachequesne]

@djaffer done!