fix: revert checking for parent workloads being controllers

This reverts the change in 07f4f34.
DeploymentConfigs on OpenShift create ReplicationControllers which in turn create Pods. However, the ReplicationControllers in this case are not marked as controllers, hence we cannot walk the list of owner references and can never scan DeploymentConfigs.

This change ensures we do not strictly check for controllers to allow us to read DeploymentConfigs.

Author: ivanstanev

src/supervisor/workload-reader.ts

@@ -224,10 +224,6 @@ export function getWorkloadReader(workloadType: string): IWorkloadReaderFunc {
 
 export function getSupportedWorkload(ownerRefs: V1OwnerReference[] | undefined): V1OwnerReference | undefined {
   return ownerRefs !== undefined
-    ? ownerRefs.find(
-        (owner) =>
-          SupportedWorkloadTypes.includes(owner.kind) &&
-          owner.controller === true,
-      )
+    ? ownerRefs.find((owner) => SupportedWorkloadTypes.includes(owner.kind))
     : undefined;
 }

test/unit/supervisor/workload-reader.spec.ts

@@ -29,18 +29,19 @@ describe('workload reader tests', () => {
       getSupportedWorkload(unsupportedOwnerRefs as V1OwnerReference[]),
     ).toBeUndefined();
 
+    // Selects the first one that matches a supported workload
     const noController = [{ kind: 'ReplicaSet' }, { kind: 'Deployment' }];
-    expect(
-      getSupportedWorkload(noController as V1OwnerReference[]),
-    ).toBeUndefined();
+    expect(getSupportedWorkload(noController as V1OwnerReference[])).toEqual({
+      kind: 'ReplicaSet',
+    });
 
+    // Selects the first one that matches a supported workload, regardless of controllers
     const oneController = [
       { kind: 'ReplicaSet' },
       { kind: 'Deployment', controller: true },
     ];
     expect(getSupportedWorkload(oneController as V1OwnerReference[])).toEqual({
-      kind: 'Deployment',
-      controller: true,
+      kind: 'ReplicaSet',
     });
 
     const twoControllers = [