Remove functions to mock ASG managed tag, since we no longer check it after PR aws#669

Author: snay2

pkg/monitor/sqsevent/sqs-monitor_test.go

@@ -148,7 +148,7 @@ func TestMonitor_EventBridgeSuccess(t *testing.T) {
 			SQS:              sqsMock,
 			EC2:              ec2Mock,
 			ManagedTag:       "aws-node-termination-handler/managed",
-			ASG:              mockIsManagedTrue(nil),
+			ASG:              &h.MockedASG{},
 			CheckIfManaged:   true,
 			QueueURL:         "https://test-queue",
 			InterruptionChan: drainChan,
@@ -192,7 +192,6 @@ func TestMonitor_EventBridgeTestNotification(t *testing.T) {
 		SQS:              sqsMock,
 		EC2:              ec2Mock,
 		ManagedTag:       "aws-node-termination-handler/managed",
-		ASG:              mockIsManagedFalse(nil),
 		CheckIfManaged:   true,
 		QueueURL:         "https://test-queue",
 		InterruptionChan: drainChan,
@@ -233,7 +232,7 @@ func TestMonitor_AsgDirectToSqsSuccess(t *testing.T) {
 		SQS:              sqsMock,
 		EC2:              ec2Mock,
 		ManagedTag:       "aws-node-termination-handler/managed",
-		ASG:              mockIsManagedTrue(nil),
+		ASG:              &h.MockedASG{},
 		CheckIfManaged:   true,
 		QueueURL:         "https://test-queue",
 		InterruptionChan: drainChan,
@@ -279,7 +278,6 @@ func TestMonitor_AsgDirectToSqsTestNotification(t *testing.T) {
 		SQS:              sqsMock,
 		EC2:              ec2Mock,
 		ManagedTag:       "aws-node-termination-handler/managed",
-		ASG:              mockIsManagedFalse(nil),
 		CheckIfManaged:   true,
 		QueueURL:         "https://test-queue",
 		InterruptionChan: drainChan,
@@ -323,7 +321,7 @@ func TestMonitor_DrainTasks(t *testing.T) {
 		SQS:              sqsMock,
 		EC2:              ec2Mock,
 		ManagedTag:       "aws-node-termination-handler/managed",
-		ASG:              mockIsManagedTrue(&asgMock),
+		ASG:              asgMock,
 		CheckIfManaged:   true,
 		QueueURL:         "https://test-queue",
 		InterruptionChan: drainChan,
@@ -372,7 +370,7 @@ func TestMonitor_DrainTasks_Errors(t *testing.T) {
 		SQS:              sqsMock,
 		EC2:              ec2Mock,
 		ManagedTag:       "aws-node-termination-handler/managed",
-		ASG:              mockIsManagedTrue(&asgMock),
+		ASG:              asgMock,
 		CheckIfManaged:   true,
 		QueueURL:         "https://test-queue",
 		InterruptionChan: drainChan,
@@ -425,7 +423,7 @@ func TestMonitor_DrainTasksASGFailure(t *testing.T) {
 		SQS:              sqsMock,
 		EC2:              ec2Mock,
 		ManagedTag:       "aws-node-termination-handler/managed",
-		ASG:              mockIsManagedTrue(&asgMock),
+		ASG:              asgMock,
 		CheckIfManaged:   true,
 		QueueURL:         "https://test-queue",
 		InterruptionChan: drainChan,
@@ -703,7 +701,6 @@ func TestMonitor_EC2NoDNSName(t *testing.T) {
 		SQS:              sqsMock,
 		EC2:              ec2Mock,
 		ManagedTag:       "aws-node-termination-handler/managed",
-		ASG:              mockIsManagedTrue(nil),
 		CheckIfManaged:   true,
 		QueueURL:         "https://test-queue",
 		InterruptionChan: drainChan,
@@ -743,7 +740,6 @@ func TestMonitor_EC2NoDNSNameOnTerminatedInstance(t *testing.T) {
 		SQS:              sqsMock,
 		EC2:              ec2Mock,
 		ManagedTag:       "aws-node-termination-handler/managed",
-		ASG:              mockIsManagedTrue(nil),
 		CheckIfManaged:   true,
 		QueueURL:         "https://test-queue",
 		InterruptionChan: drainChan,
@@ -781,7 +777,6 @@ func TestMonitor_SQSDeleteFailure(t *testing.T) {
 		SQS:              sqsMock,
 		EC2:              ec2Mock,
 		ManagedTag:       "aws-node-termination-handler/managed",
-		ASG:              mockIsManagedTrue(nil),
 		CheckIfManaged:   true,
 		QueueURL:         "https://test-queue",
 		InterruptionChan: drainChan,
@@ -819,7 +814,6 @@ func TestMonitor_InstanceNotManaged(t *testing.T) {
 		sqsMonitor := sqsevent.SQSMonitor{
 			SQS:              sqsMock,
 			EC2:              ec2Mock,
-			ASG:              mockIsManagedFalse(nil),
 			CheckIfManaged:   true,
 			QueueURL:         "https://test-queue",
 			InterruptionChan: drainChan,
@@ -875,30 +869,3 @@ func getSQSMessageFromEvent(event sqsevent.EventBridgeEvent) (sqs.Message, error
 	eventStr := string(eventBytes)
 	return sqs.Message{Body: &eventStr}, nil
 }
-
-func mockIsManagedTrue(asg *h.MockedASG) h.MockedASG {
-	if asg == nil {
-		asg = &h.MockedASG{}
-	}
-	asg.DescribeAutoScalingInstancesResp = autoscaling.DescribeAutoScalingInstancesOutput{
-		AutoScalingInstances: []*autoscaling.InstanceDetails{
-			{AutoScalingGroupName: aws.String("test-asg")},
-		},
-	}
-	asg.DescribeTagsPagesResp = autoscaling.DescribeTagsOutput{
-		Tags: []*autoscaling.TagDescription{
-			{Key: aws.String("aws-node-termination-handler/managed")},
-		},
-	}
-	return *asg
-}
-
-func mockIsManagedFalse(asg *h.MockedASG) h.MockedASG {
-	if asg == nil {
-		asg = &h.MockedASG{}
-	}
-	asg.DescribeAutoScalingInstancesResp = autoscaling.DescribeAutoScalingInstancesOutput{
-		AutoScalingInstances: []*autoscaling.InstanceDetails{},
-	}
-	return *asg
-}