feat: schema code generation #1599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
force-pushed
the
schema/java-codegen
branch
2 times, most recently
from
b4454c3 to
8ce473b
Compare
kuhe
force-pushed
the
schema/java-codegen
branch
2 times, most recently
from
52fe0ac to
76c6222
Compare
kuhe
force-pushed
the
schema/java-codegen
branch
3 times, most recently
from
e5141bc to
ae31af9
Compare
siddsriv
reviewed
May 29, 2025
| return SchemaTraitExtension.INSTANCE.render(trait); | ||
| } | ||
| return """ | ||
| /* unhandled trait \s""" + "`" + trait.getClass().getSimpleName() + "` */"; |
There was a problem hiding this comment.
would this be better returned as a warning/error of sorts?
There was a problem hiding this comment.
There's going to be some additional handling in a later PR for this.
siddsriv
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds schema code generation and an allow-list API (currently empty).
original working branch: #1592
group:
#1593 - schema types
#1594 - migrate serde functions
#1595 - schema runtime classes
#1601 - rpcv2 cbor runtime protocol
#1599 - java codegen