Bump Rust MSRV to 1.63.0 (#2222)

Co-authored-by: Zelda Hessler <[email protected]>
Co-authored-by: John DiSanti <[email protected]>

Author: 3 people

.github/workflows/ci.yml

@@ -29,7 +29,7 @@ on:
         required: false
 
 env:
-  rust_version: 1.62.1
+  rust_version: 1.63.0
   rust_toolchain_components: clippy,rustfmt
   ENCRYPTED_DOCKER_PASSWORD: ${{ secrets.ENCRYPTED_DOCKER_PASSWORD }}
   DOCKER_LOGIN_TOKEN_PASSPHRASE: ${{ secrets.DOCKER_LOGIN_TOKEN_PASSPHRASE }}

.github/workflows/claim-crate-names.yml

@@ -10,7 +10,7 @@ concurrency:
   cancel-in-progress: true
 
 env:
-  rust_version: 1.62.1
+  rust_version: 1.63.0
 
 name: Claim unpublished crate names on crates.io
 run-name: ${{ github.workflow }}

.github/workflows/pull-request-bot.yml

@@ -28,7 +28,7 @@ concurrency:
 
 env:
   java_version: 11
-  rust_version: 1.62.1
+  rust_version: 1.63.0
   rust_toolchain_components: clippy,rustfmt
   apt_dependencies: libssl-dev gnuplot jq
 

.github/workflows/release.yml

@@ -10,16 +10,16 @@ concurrency:
   cancel-in-progress: true
 
 env:
-  rust_version: 1.62.1
+  rust_version: 1.63.0
 
 name: Release smithy-rs
 run-name: ${{ github.workflow }} ${{ inputs.semantic_version }} (${{ inputs.commit_sha }}) - ${{ inputs.dry_run && 'Dry run' || 'Production run' }}
 on:
   workflow_dispatch:
     inputs:
       commit_sha:
-        description: | 
-          The SHA of the git commit that you want to release.  
+        description: |
+          The SHA of the git commit that you want to release.
           You must use the non-abbreviated SHA (e.g. b2318b0 won't work!).
         required: true
         type: string
@@ -75,8 +75,8 @@ jobs:
     # We need `always` here otherwise this job won't run if the previous job has been skipped
     # See https://samanpavel.medium.com/github-actions-conditional-job-execution-e6aa363d2867
     if: |
-      always() && 
-      needs.acquire-base-image.result == 'success' && 
+      always() &&
+      needs.acquire-base-image.result == 'success' &&
       (needs.release-ci.result == 'success' || needs.release-ci.result == 'skipped')
     runs-on: ubuntu-latest
     outputs:
@@ -234,7 +234,7 @@ jobs:
       shell: bash
       run: |
         set -eux
-        
+
         # This will fail if other commits have been pushed to `main` after `commit_sha`
         # In particular, this will ALWAYS fail if you are creating a new release series from
         # a commit that is not the current tip of `main`.

.github/workflows/update-sdk-next.yml

@@ -32,7 +32,7 @@ jobs:
     - name: Set up Rust
       uses: dtolnay/rust-toolchain@master
       with:
-        toolchain: 1.62.1
+        toolchain: 1.63.0
     - name: Delete old SDK
       run: |
     - name: Generate a fresh SDK

CHANGELOG.next.toml

@@ -10,3 +10,15 @@
 # references = ["smithy-rs#920"]
 # meta = { "breaking" = false, "tada" = false, "bug" = false, "target" = "client | server | all"}
 # author = "rcoh"
+
+[[aws-sdk-rust]]
+message = "Upgrade Rust MSRV to 1.63.0"
+references = ["smithy-rs#2222"]
+meta = { "breaking" = true, "tada" = true, "bug" = false }
+author = "Nugine"
+
+[[smithy-rs]]
+message = "Upgrade Rust MSRV to 1.63.0"
+references = ["smithy-rs#2222"]
+meta = { "breaking" = true, "tada" = true, "bug" = false, "target" = "all" }
+author = "Nugine"

aws/rust-runtime/aws-config/src/imds/client.rs

@@ -917,7 +917,7 @@ pub(crate) mod test {
                 imds_request("http://169.254.169.254/latest/metadata", TOKEN_A),
                 http::Response::builder()
                     .status(200)
-                    .body(SdkBody::from(vec![0xA0 as u8, 0xA1 as u8]))
+                    .body(SdkBody::from(vec![0xA0, 0xA1]))
                     .unwrap(),
             ),
         ]);

aws/rust-runtime/aws-config/src/lib.rs

@@ -3,6 +3,7 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
+#![allow(clippy::derive_partial_eq_without_eq)]
 #![warn(
     missing_debug_implementations,
     missing_docs,

aws/rust-runtime/aws-credential-types/src/lib.rs

@@ -8,6 +8,7 @@
 //! * An opaque struct representing credentials
 //! * Concrete implementations of credentials caching
 
+#![allow(clippy::derive_partial_eq_without_eq)]
 #![warn(
     missing_debug_implementations,
     missing_docs,

aws/rust-runtime/aws-endpoint/src/lib.rs

@@ -3,6 +3,8 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
+#![allow(clippy::derive_partial_eq_without_eq)]
+
 use std::collections::HashMap;
 use std::error::Error;
 use std::fmt;
@@ -270,7 +272,7 @@ mod test {
         let mut req = operation::Request::new(req);
         {
             let mut props = req.properties_mut();
-            props.insert(region.clone());
+            props.insert(region);
             props.insert(SigningService::from_static("qldb"));
             props.insert(endpoint);
         };