This repository was archived by the owner on Mar 17, 2022. It is now read-only.
Add docker support #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker instructions
|
Regarding NPM install errors: do you encounter this error with Yarn as well? I think the error is related to the OS, but this repository includes a yarn lockfile, so I would prefer we use that. |
boxhock
suggested changes
Jan 22, 2020
Using yarn instead of npm.
Removing "docker run" optional parameters.
boxhock
suggested changes
Feb 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated README.
Added docker file.
Please read before merge:
During npm install there is a point where it is trying to do a "node-gyp rebuild".
This will fail with many dependency misses. In order to fix the dependencies the following packages are added to the image: python and alpine-sdk.
After adding the packages it is no longer prompting errors buy a big load of warnings such as:
warning: cast between incompatible function typesThe adapter seems to be working correctly in both cases (with or without the dependencies above).