fix: filter out tools with array parameters for non-claude models

Author: humbertoyusta

refact-agent/engine/src/scratchpads/chat_passthrough.rs

@@ -195,7 +195,7 @@ impl ScratchpadAbstract for ChatPassthrough {
                 } else {
                     let allow_experimental = gcx.read().await.cmdline.experimental;
                     let tool_descriptions = tool_description_list_from_yaml(at_tools, Some(&turned_on), allow_experimental).await?;
-                    Some(tool_descriptions.into_iter().map(|x: crate::tools::tools_description::ToolDesc|x.into_openai_style()).collect::<Vec<_>>())
+                    Some(tool_descriptions.into_iter().filter(|x| x.is_supported_by(&self.post.model)).map(|x| x.into_openai_style()).collect::<Vec<_>>())
                 }
             } else {
                 None

refact-agent/engine/src/subchat.rs

@@ -295,7 +295,7 @@ pub async fn subchat_single(
         error!("Error loading compiled_in_tools: {:?}", e);
         vec![]
     });
-    let tools = tools_desclist.into_iter().map(|x|x.into_openai_style()).collect::<Vec<_>>();
+    let tools = tools_desclist.into_iter().filter(|x| x.is_supported_by(model_name)).map(|x|x.into_openai_style()).collect::<Vec<_>>();
     info!("tools_subset {:?}", tools_subset);
     info!("tools_turned_on_by_cmdline_set {:?}", tools_turned_on_by_cmdline_set);
     info!("tools_on_intersection {:?}", tools_on_intersection);

refact-agent/engine/src/tools/tools_description.rs

@@ -565,6 +565,13 @@ fn default_param_type() -> String {
     "string".to_string()
 }
 
+/// TODO: Think a better way to know if we can send array type to the model
+/// 
+/// For now, anthropic models support it, gpt models don't, for other, we'll need to test
+pub fn model_supports_array_param_type(model_name: &str) -> bool {
+    model_name.starts_with("claude")
+}
+
 pub fn make_openai_tool_value(
     name: String,
     agentic: bool,
@@ -608,6 +615,18 @@ impl ToolDesc {
             self.parameters,
         )
     }
+
+    pub fn is_supported_by(&self, model: &str) -> bool {
+        if !model_supports_array_param_type(model) {
+            for param in &self.parameters {
+                if param.param_type == "array" {
+                    tracing::error!("Tool {} has array parameter, but model {} does not support it", self.name, model);
+                    return false;
+                }
+            }
+        }
+        true
+    }
 }
 
 #[derive(Deserialize)]