Skip to content

Fix warnings from collections #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix warnings from collections #23

wants to merge 1 commit into from

Conversation

yan12125
Copy link

Specifically, the following DeprecationWarning due to changes in Python
3.7 [1]

/home/yen/Projects/python-frozendict/frozendict/__init__.py:16: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
  class frozendict(collections.Mapping):

Tested with:

$ PYTHONWARNINGS=all python3 -c 'from frozendict import frozendict'
$ PYTHONWARNINGS=all python2 -c 'from frozendict import frozendict'

[1] python/cpython#5460

Specifically, the following DeprecationWarning due to changes in Python
3.7 [1]

/home/yen/Projects/python-frozendict/frozendict/__init__.py:16: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
  class frozendict(collections.Mapping):

[1] python/cpython#5460
@yan12125
Copy link
Author

Hi I noticed that this pull request is approved but not merged. Is there anything left to be fixed?

@yan12125
Copy link
Author

@slezica ping

@austin1howard
Copy link

@yan12125 I'm worried this project is more-or-less abandoned, @slezica hasn't committed to github in a long time.

@yan12125
Copy link
Author

I created this pull request to make ycmd compatible with future Python versions. Now I switched to coc.nvim, so the issue is no longer relevant.

I hereby declare the commit cd5b529 licensed as MIT, the same license as python-frozendict. If anyone else want to continue the work, feel free to take my patch.

@yan12125 yan12125 closed this Nov 17, 2019
@yan12125 yan12125 deleted the fix-collections-warning branch November 17, 2019 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants