allow specifying a VPC from another GCP project #5143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeungjinYang
changed the title
Michaelvll
approved these changes
Apr 8, 2025
Comment on lines
+578
to
+581
| if len(split_vpc_value) != 2: | ||
| raise ValueError(f'Invalid VPC name: {specific_vpc_to_use}. ' | ||
| 'Please specify the VPC name in the format ' | ||
| 'PROJECT_ID/VPC_NAME.') |
There was a problem hiding this comment.
We should add this check in jsonschema for config to fail early
There was a problem hiding this comment.
Also, might be good to add a quick unit test for specifying wrong format of vpc name.
Co-authored-by: Zhanghao Wu <[email protected]>
|
test failure is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5141.
Tested (run the relevant ones):
bash format.sh