-
Notifications
You must be signed in to change notification settings - Fork 698
Replacing 'create' trigger for 'push' in Step 0 #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The 'create' trigger does not get picked up once you create a repository from a template. Instead, the 'push' trigger should be used here for this purpose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on:
workflow_dispatch:
push:
branches:
- main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matches introduction to GitHub
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Buttons 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls review
The 'create' trigger does not get picked up once you create a repository from a template. Instead, the 'push' trigger should be used here for this purpose.
Summary
When following the steps in the template repository README and creating a new repository from the template, the GitHub Actions Workflow for 'Step 0: Welcome' does not get triggered. This is because the trigger 'create' being used does not trigger the workflow on this type of event. The only exception to this is if the user creates the repository from the template with the checkbox 'Include all branches' selected. This counts as a branch creation and thus triggers the workflow, however this is not the default option and should not be expected of users.
Changes
Using the
push
trigger. As per documentation, thepush
trigger runs your workflow when you push a commit or tag, or when you create a repository from a template.Closes:
#87
Task list