Merge pull request #481 from sir-gon/develop

[BUGFIX] sonarcloud quality gate issues fixed

Author: sir-gon

src/hackerrank/interview_preparation_kit/sort/ctci_comparator_sorting.Player.ts

@@ -1,22 +1,16 @@
-// Start Given code
-
 export class Player {
   name = '';
 
   score = 0;
 
-  toString(): string {
-    // Given code
-    this.name.toString();
-    return '';
+  constructor(name: string, score: number) {
+    this.name = name;
+    this.score = score;
   }
 
-  comparator(bPlayer: this): number {
-    // Given code
-    return 0 * this.score * bPlayer.score;
+  toString(): string {
+    return `${this.name} ${this.score}`;
   }
 }
 
-// End Given code
-
 export default { Player };

src/hackerrank/interview_preparation_kit/sort/ctci_comparator_sorting.test.ts

@@ -11,18 +11,16 @@ import TEST_CASES from './ctci_comparator_sorting.testcases.json';
 
 describe('comparatorSorting', () => {
   it('test_player', () => {
-    expect.assertions(2);
+    expect.assertions(1);
 
-    const aPlayer = new Player();
+    const _NAME_ = 'name';
+    const _SCORE_ = 0;
+
+    const aPlayer = new Player(_NAME_, _SCORE_);
     const aPlayerAsString = aPlayer.toString();
-    const aExpected = '';
+    const aExpected = 'name 0';
 
     expect(aExpected).toStrictEqual(aPlayerAsString);
-
-    const bPlayer = new Player();
-    const comparatorAnswerExpected = 0;
-
-    expect(aPlayer.comparator(bPlayer)).toStrictEqual(comparatorAnswerExpected);
   });
 
   it('test_comparator_sorting', () => {

src/hackerrank/interview_preparation_kit/sort/ctci_comparator_sorting.ts

@@ -10,16 +10,12 @@ export class SortablePlayer extends Player {
   score = 0;
 
   constructor(name: string, score: number) {
-    super();
+    super(name, score);
 
     this.name = name;
     this.score = score;
   }
 
-  toString(): string {
-    return `${this.name} ${this.score}`;
-  }
-
   comparator(bPlayer: this): number {
     if (this.score > bPlayer.score) {
       return -1;