Skip to content

Revert "Remove unused method" #479

Revert "Remove unused method"

Revert "Remove unused method" #479

Triggered via push November 12, 2025 19:28
Status Failure
Total duration 1m 30s
Artifacts

php.yml

on: push
Matrix: unit-tests-linux
Matrix: unit-tests-windows
Code coverage
0s
Code coverage
Cleanup artifacts
0s
Cleanup artifacts
Fit to window
Zoom out
Zoom in

Annotations

19 errors and 15 warnings
Quality control
Process completed with exit code 2.
UnusedIssueHandlerSuppression: psalm-dev.xml#L0
/home/runner/work/simplesamlphp-module-adfs/simplesamlphp-module-adfs/psalm-dev.xml:0:0: UnusedIssueHandlerSuppression: Suppressed issue type "UnresolvableInclude" for /tests/bootstrap.php was not thrown. (see https://psalm.dev/326)
MissingOverrideAttribute: tests/src/Controller/AdfsControllerTest.php#L32
tests/src/Controller/AdfsControllerTest.php:32:5: MissingOverrideAttribute: Method SimpleSAML\Test\Module\adfs\Controller\AdfsControllerTest::setup should have the "Override" attribute (see https://psalm.dev/358)
UnusedClass: tests/src/Controller/AdfsControllerTest.php#L20
tests/src/Controller/AdfsControllerTest.php:20:7: UnusedClass: Class SimpleSAML\Test\Module\adfs\Controller\AdfsControllerTest is never used (see https://psalm.dev/075)
UnusedVariable: tests/metadata/adfs-sp-remote.php#L3
tests/metadata/adfs-sp-remote.php:3:1: UnusedVariable: $metadata is never referenced or the value is not used (see https://psalm.dev/077)
UnusedVariable: tests/metadata/adfs-idp-hosted.php#L6
tests/metadata/adfs-idp-hosted.php:6:1: UnusedVariable: $metadata is never referenced or the value is not used (see https://psalm.dev/077)
UnusedVariable: tests/metadata/adfs-idp-hosted.php#L5
tests/metadata/adfs-idp-hosted.php:5:1: UnusedVariable: $certDir is never referenced or the value is not used (see https://psalm.dev/077)
UnusedVariable: tests/config/authsources.php#L3
tests/config/authsources.php:3:1: UnusedVariable: $config is never referenced or the value is not used (see https://psalm.dev/077)
UnusedClass: tests/InterOperability/DefinitionsTest.php#L19
tests/InterOperability/DefinitionsTest.php:19:13: UnusedClass: Class SimpleSAML\Test\Module\adfs\InterOperability\DefinitionsTest is never used (see https://psalm.dev/075)
UndefinedDocblockClass: src/Controller/Adfs.php#L162
src/Controller/Adfs.php:162:21: UndefinedDocblockClass: Docblock-defined class, interface or enum named SimpleSAML\WSSecurity\XML\wsdl\Definitions does not exist (see https://psalm.dev/200)
InternalMethod: src/Controller/Adfs.php#L131
src/Controller/Adfs.php:131:37: InternalMethod: The method Symfony\Component\HttpFoundation\Request::get is internal to Symfony but called from SimpleSAML\Module\adfs\Controller\Adfs::prp (see https://psalm.dev/175)
InternalMethod: src/Controller/Adfs.php#L129
src/Controller/Adfs.php:129:34: InternalMethod: The method Symfony\Component\HttpFoundation\Request::get is internal to Symfony but called from SimpleSAML\Module\adfs\Controller\Adfs::prp (see https://psalm.dev/175)
InternalMethod: src/Controller/Adfs.php#L126
src/Controller/Adfs.php:126:29: InternalMethod: The method Symfony\Component\HttpFoundation\Request::get is internal to Symfony but called from SimpleSAML\Module\adfs\Controller\Adfs::prp (see https://psalm.dev/175)
InternalMethod: src/Controller/Adfs.php#L115
src/Controller/Adfs.php:115:29: InternalMethod: The method Symfony\Component\HttpFoundation\Request::get is internal to Symfony but called from SimpleSAML\Module\adfs\Controller\Adfs::prp (see https://psalm.dev/175)
InternalMethod: src/Controller/Adfs.php#L114
src/Controller/Adfs.php:114:23: InternalMethod: The method Symfony\Component\HttpFoundation\Request::get is internal to Symfony but called from SimpleSAML\Module\adfs\Controller\Adfs::prp (see https://psalm.dev/175)
PossiblyNullArgument: src/Controller/Adfs.php#L76
src/Controller/Adfs.php:76:59: PossiblyNullArgument: Argument 1 of SimpleSAML\Metadata\MetaDataStorageHandler::getMetaDataConfig cannot be null, possibly null value provided (see https://psalm.dev/078)
ArgumentTypeCoercion: src/Controller/Adfs.php#L76
src/Controller/Adfs.php:76:59: ArgumentTypeCoercion: Argument 1 of SimpleSAML\Metadata\MetaDataStorageHandler::getMetaDataConfig expects string, but parent type null|scalar provided (see https://psalm.dev/193)
TooManyArguments: src/Controller/Adfs.php#L48
src/Controller/Adfs.php:48:27: TooManyArguments: Too many arguments for SimpleSAML\Metadata\MetaDataStorageHandler::getMetadataHandler - expecting 0 but saw 1 (see https://psalm.dev/026)
ClassMustBeFinal: src/Controller/Adfs.php#L25
src/Controller/Adfs.php:25:7: ClassMustBeFinal: Class SimpleSAML\Module\adfs\Controller\Adfs is never extended and is not part of the public API, and thus must be made final. (see https://psalm.dev/361)
PropertyNotSetInConstructor: tests/src/Controller/AdfsControllerTest.php#L26
tests/src/Controller/AdfsControllerTest.php:26:23: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\adfs\Controller\AdfsControllerTest::$session is not defined in constructor of SimpleSAML\Test\Module\adfs\Controller\AdfsControllerTest or in any methods called in the constructor (see https://psalm.dev/074)
PropertyNotSetInConstructor: tests/src/Controller/AdfsControllerTest.php#L23
tests/src/Controller/AdfsControllerTest.php:23:29: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\adfs\Controller\AdfsControllerTest::$config is not defined in constructor of SimpleSAML\Test\Module\adfs\Controller\AdfsControllerTest or in any methods called in the constructor (see https://psalm.dev/074)
ClassMustBeFinal: tests/src/Controller/AdfsControllerTest.php#L20
tests/src/Controller/AdfsControllerTest.php:20:7: ClassMustBeFinal: Class SimpleSAML\Test\Module\adfs\Controller\AdfsControllerTest is never extended and is not part of the public API, and thus must be made final. (see https://psalm.dev/361)
PossiblyUndefinedGlobalVariable: tests/metadata/adfs-sp-remote.php#L3
tests/metadata/adfs-sp-remote.php:3:1: PossiblyUndefinedGlobalVariable: Possibly undefined global variable $metadata, first seen on line 3 (see https://psalm.dev/126)
PossiblyUndefinedGlobalVariable: tests/metadata/adfs-idp-hosted.php#L6
tests/metadata/adfs-idp-hosted.php:6:1: PossiblyUndefinedGlobalVariable: Possibly undefined global variable $metadata, first seen on line 6 (see https://psalm.dev/126)
MixedPropertyAssignment: src/Controller/Adfs.php#L165
src/Controller/Adfs.php:165:9: MixedPropertyAssignment: $document->ownerDocument of type mixed cannot be assigned to (see https://psalm.dev/033)
MixedPropertyAssignment: src/Controller/Adfs.php#L164
src/Controller/Adfs.php:164:9: MixedPropertyAssignment: $document->ownerDocument of type mixed cannot be assigned to (see https://psalm.dev/033)
MixedPropertyFetch: src/Controller/Adfs.php#L164
src/Controller/Adfs.php:164:9: MixedPropertyFetch: Cannot fetch property on mixed var $document (see https://psalm.dev/034)
MixedAssignment: src/Controller/Adfs.php#L162
src/Controller/Adfs.php:162:9: MixedAssignment: Unable to determine the type that $document is being assigned to (see https://psalm.dev/032)
MixedArgument: src/Controller/Adfs.php#L137
src/Controller/Adfs.php:137:58: MixedArgument: Argument 2 of SimpleSAML\IdP::handleLogoutResponse cannot be mixed, expecting null|string (see https://psalm.dev/030)
MixedArgument: src/Controller/Adfs.php#L137
src/Controller/Adfs.php:137:48: MixedArgument: Argument 1 of SimpleSAML\IdP::handleLogoutResponse cannot be mixed, expecting string (see https://psalm.dev/030)
MixedAssignment: src/Controller/Adfs.php#L131
src/Controller/Adfs.php:131:13: MixedAssignment: Unable to determine the type that $relayState is being assigned to (see https://psalm.dev/032)
MixedAssignment: src/Controller/Adfs.php#L129
src/Controller/Adfs.php:129:13: MixedAssignment: Unable to determine the type that $assocId is being assigned to (see https://psalm.dev/032)
MixedAssignment: src/Controller/Adfs.php#L115
src/Controller/Adfs.php:115:13: MixedAssignment: Unable to determine the type that $wa is being assigned to (see https://psalm.dev/032)
UnusedClass: src/Controller/Adfs.php#L25
src/Controller/Adfs.php:25:7: UnusedClass: Class SimpleSAML\Module\adfs\Controller\Adfs is never used (see https://psalm.dev/075)