Skip to content

Tests failing due to updated tabulate library #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
simonw opened this issue Oct 18, 2022 · 4 comments
Closed

Tests failing due to updated tabulate library #501

simonw opened this issue Oct 18, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@simonw
Copy link
Owner

simonw commented Oct 18, 2022

Failure here: https://github.com/simonw/sqlite-utils/actions/runs/3275786702/jobs/5391063221

I figured out the problem:

diff --git a/docs/cli-reference.rst b/docs/cli-reference.rst
index b88e38a..82b4b6c 100644
--- a/docs/cli-reference.rst
+++ b/docs/cli-reference.rst
@@ -112,11 +112,15 @@ See :ref:`cli_query`.
       --tsv                       Output TSV
       --no-headers                Omit CSV headers
       -t, --table                 Output as a formatted table
-      --fmt TEXT                  Table format - one of fancy_grid, fancy_outline,
-                                  github, grid, html, jira, latex, latex_booktabs,
-                                  latex_longtable, latex_raw, mediawiki, moinmoin,
-                                  orgtbl, pipe, plain, presto, pretty, psql, rst,
-                                  simple, textile, tsv, unsafehtml, youtrack
+      --fmt TEXT                  Table format - one of asciidoc, double_grid,
+                                  double_outline, fancy_grid, fancy_outline, github,
+                                  grid, heavy_grid, heavy_outline, html, jira,
+                                  latex, latex_booktabs, latex_longtable, latex_raw,
+                                  mediawiki, mixed_grid, mixed_outline, moinmoin,
+                                  orgtbl, outline, pipe, plain, presto, pretty,
+                                  psql, rounded_grid, rounded_outline, rst, simple,
+                                  simple_grid, simple_outline, textile, tsv,
+                                  unsafehtml, youtrack
       --json-cols                 Detect JSON cols and output them as JSON, not
                                   escaped strings
       -r, --raw                   Raw output, first column of first row
@@ -176,11 +180,15 @@ See :ref:`cli_memory`.
       --tsv                       Output TSV
       --no-headers                Omit CSV headers
       -t, --table                 Output as a formatted table
-      --fmt TEXT                  Table format - one of fancy_grid, fancy_outline,
-                                  github, grid, html, jira, latex, latex_booktabs,
-                                  latex_longtable, latex_raw, mediawiki, moinmoin,
-                                  orgtbl, pipe, plain, presto, pretty, psql, rst,
-                                  simple, textile, tsv, unsafehtml, youtrack
+      --fmt TEXT                  Table format - one of asciidoc, double_grid,
+                                  double_outline, fancy_grid, fancy_outline, github,
+                                  grid, heavy_grid, heavy_outline, html, jira,
+                                  latex, latex_booktabs, latex_longtable, latex_raw,
+                                  mediawiki, mixed_grid, mixed_outline, moinmoin,
+                                  orgtbl, outline, pipe, plain, presto, pretty,
+                                  psql, rounded_grid, rounded_outline, rst, simple,
+                                  simple_grid, simple_outline, textile, tsv,
+                                  unsafehtml, youtrack
       --json-cols                 Detect JSON cols and output them as JSON, not
                                   escaped strings
       -r, --raw                   Raw output, first column of first row
@@ -401,11 +409,14 @@ See :ref:`cli_search`.
       --tsv                  Output TSV
       --no-headers           Omit CSV headers
       -t, --table            Output as a formatted table
-      --fmt TEXT             Table format - one of fancy_grid, fancy_outline,
-                             github, grid, html, jira, latex, latex_booktabs,
-                             latex_longtable, latex_raw, mediawiki, moinmoin,
-                             orgtbl, pipe, plain, presto, pretty, psql, rst, simple,
-                             textile, tsv, unsafehtml, youtrack
+      --fmt TEXT             Table format - one of asciidoc, double_grid,
+                             double_outline, fancy_grid, fancy_outline, github,
+                             grid, heavy_grid, heavy_outline, html, jira, latex,
+                             latex_booktabs, latex_longtable, latex_raw, mediawiki,
+                             mixed_grid, mixed_outline, moinmoin, orgtbl, outline,
+                             pipe, plain, presto, pretty, psql, rounded_grid,
+                             rounded_outline, rst, simple, simple_grid,
+                             simple_outline, textile, tsv, unsafehtml, youtrack
       --json-cols            Detect JSON cols and output them as JSON, not escaped
                              strings
       --load-extension TEXT  Path to SQLite extension, with optional :entrypoint
@@ -651,11 +662,14 @@ See :ref:`cli_tables`.
       --tsv                  Output TSV
       --no-headers           Omit CSV headers
       -t, --table            Output as a formatted table
-      --fmt TEXT             Table format - one of fancy_grid, fancy_outline,
-                             github, grid, html, jira, latex, latex_booktabs,
-                             latex_longtable, latex_raw, mediawiki, moinmoin,
-                             orgtbl, pipe, plain, presto, pretty, psql, rst, simple,
-                             textile, tsv, unsafehtml, youtrack
+      --fmt TEXT             Table format - one of asciidoc, double_grid,
+                             double_outline, fancy_grid, fancy_outline, github,
+                             grid, heavy_grid, heavy_outline, html, jira, latex,
+                             latex_booktabs, latex_longtable, latex_raw, mediawiki,
+                             mixed_grid, mixed_outline, moinmoin, orgtbl, outline,
+                             pipe, plain, presto, pretty, psql, rounded_grid,
+                             rounded_outline, rst, simple, simple_grid,
+                             simple_outline, textile, tsv, unsafehtml, youtrack
       --json-cols            Detect JSON cols and output them as JSON, not escaped
                              strings
       --columns              Include list of columns for each table
@@ -689,11 +703,14 @@ See :ref:`cli_views`.
       --tsv                  Output TSV
       --no-headers           Omit CSV headers
       -t, --table            Output as a formatted table
-      --fmt TEXT             Table format - one of fancy_grid, fancy_outline,
-                             github, grid, html, jira, latex, latex_booktabs,
-                             latex_longtable, latex_raw, mediawiki, moinmoin,
-                             orgtbl, pipe, plain, presto, pretty, psql, rst, simple,
-                             textile, tsv, unsafehtml, youtrack
+      --fmt TEXT             Table format - one of asciidoc, double_grid,
+                             double_outline, fancy_grid, fancy_outline, github,
+                             grid, heavy_grid, heavy_outline, html, jira, latex,
+                             latex_booktabs, latex_longtable, latex_raw, mediawiki,
+                             mixed_grid, mixed_outline, moinmoin, orgtbl, outline,
+                             pipe, plain, presto, pretty, psql, rounded_grid,
+                             rounded_outline, rst, simple, simple_grid,
+                             simple_outline, textile, tsv, unsafehtml, youtrack
       --json-cols            Detect JSON cols and output them as JSON, not escaped
                              strings
       --columns              Include list of columns for each view
@@ -732,11 +749,15 @@ See :ref:`cli_rows`.
       --tsv                       Output TSV
       --no-headers                Omit CSV headers
       -t, --table                 Output as a formatted table
-      --fmt TEXT                  Table format - one of fancy_grid, fancy_outline,
-                                  github, grid, html, jira, latex, latex_booktabs,
-                                  latex_longtable, latex_raw, mediawiki, moinmoin,
-                                  orgtbl, pipe, plain, presto, pretty, psql, rst,
-                                  simple, textile, tsv, unsafehtml, youtrack
+      --fmt TEXT                  Table format - one of asciidoc, double_grid,
+                                  double_outline, fancy_grid, fancy_outline, github,
+                                  grid, heavy_grid, heavy_outline, html, jira,
+                                  latex, latex_booktabs, latex_longtable, latex_raw,
+                                  mediawiki, mixed_grid, mixed_outline, moinmoin,
+                                  orgtbl, outline, pipe, plain, presto, pretty,
+                                  psql, rounded_grid, rounded_outline, rst, simple,
+                                  simple_grid, simple_outline, textile, tsv,
+                                  unsafehtml, youtrack
       --json-cols                 Detect JSON cols and output them as JSON, not
                                   escaped strings
       --load-extension TEXT       Path to SQLite extension, with optional
@@ -768,11 +789,14 @@ See :ref:`cli_triggers`.
       --tsv                  Output TSV
       --no-headers           Omit CSV headers
       -t, --table            Output as a formatted table
-      --fmt TEXT             Table format - one of fancy_grid, fancy_outline,
-                             github, grid, html, jira, latex, latex_booktabs,
-                             latex_longtable, latex_raw, mediawiki, moinmoin,
-                             orgtbl, pipe, plain, presto, pretty, psql, rst, simple,
-                             textile, tsv, unsafehtml, youtrack
+      --fmt TEXT             Table format - one of asciidoc, double_grid,
+                             double_outline, fancy_grid, fancy_outline, github,
+                             grid, heavy_grid, heavy_outline, html, jira, latex,
+                             latex_booktabs, latex_longtable, latex_raw, mediawiki,
+                             mixed_grid, mixed_outline, moinmoin, orgtbl, outline,
+                             pipe, plain, presto, pretty, psql, rounded_grid,
+                             rounded_outline, rst, simple, simple_grid,
+                             simple_outline, textile, tsv, unsafehtml, youtrack
       --json-cols            Detect JSON cols and output them as JSON, not escaped
                              strings
       --load-extension TEXT  Path to SQLite extension, with optional :entrypoint
@@ -804,11 +828,14 @@ See :ref:`cli_indexes`.
       --tsv                  Output TSV
       --no-headers           Omit CSV headers
       -t, --table            Output as a formatted table
-      --fmt TEXT             Table format - one of fancy_grid, fancy_outline,
-                             github, grid, html, jira, latex, latex_booktabs,
-                             latex_longtable, latex_raw, mediawiki, moinmoin,
-                             orgtbl, pipe, plain, presto, pretty, psql, rst, simple,
-                             textile, tsv, unsafehtml, youtrack
+      --fmt TEXT             Table format - one of asciidoc, double_grid,
+                             double_outline, fancy_grid, fancy_outline, github,
+                             grid, heavy_grid, heavy_outline, html, jira, latex,
+                             latex_booktabs, latex_longtable, latex_raw, mediawiki,
+                             mixed_grid, mixed_outline, moinmoin, orgtbl, outline,
+                             pipe, plain, presto, pretty, psql, rounded_grid,
+                             rounded_outline, rst, simple, simple_grid,
+                             simple_outline, textile, tsv, unsafehtml, youtrack
       --json-cols            Detect JSON cols and output them as JSON, not escaped
                              strings
       --load-extension TEXT  Path to SQLite extension, with optional :entrypoint
diff --git a/docs/cli.rst b/docs/cli.rst
index 8bc4176..1d67e88 100644
--- a/docs/cli.rst
+++ b/docs/cli.rst
@@ -187,10 +187,15 @@ Available ``--fmt`` options are:
     cog.out("\n" + "\n".join('- ``{}``'.format(t) for t in tabulate.tabulate_formats) + "\n\n")
 .. ]]]
 
+- ``asciidoc``
+- ``double_grid``
+- ``double_outline``
 - ``fancy_grid``
 - ``fancy_outline``
 - ``github``
 - ``grid``
+- ``heavy_grid``
+- ``heavy_outline``
 - ``html``
 - ``jira``
 - ``latex``
@@ -198,15 +203,22 @@ Available ``--fmt`` options are:
 - ``latex_longtable``
 - ``latex_raw``
 - ``mediawiki``
+- ``mixed_grid``
+- ``mixed_outline``
 - ``moinmoin``
 - ``orgtbl``
+- ``outline``
 - ``pipe``
 - ``plain``
 - ``presto``
 - ``pretty``
 - ``psql``
+- ``rounded_grid``
+- ``rounded_outline``
 - ``rst``
 - ``simple``
+- ``simple_grid``
+- ``simple_outline``
 - ``textile``
 - ``tsv``
 - ``unsafehtml``
@simonw simonw added the bug Something isn't working label Oct 18, 2022
@simonw
Copy link
Owner Author

simonw commented Oct 18, 2022

@simonw
Copy link
Owner Author

simonw commented Oct 18, 2022

Now the 3.6 tests fail - because the new release of tabulate dropped support for that Python version (so on Python 3.6 you get an older version): https://github.com/simonw/sqlite-utils/actions/runs/3275842849/jobs/5391181675

https://github.com/astanin/python-tabulate/blame/20c6370d5da2dae89b305bfb6c7f12a0f8b7236c/pyproject.toml#L22 shows minimum is 3.7 now.

@simonw
Copy link
Owner Author

simonw commented Oct 18, 2022

I'm going to skip the cog test on Python 3.6 to address this. The documentation on the website will show the available list of options for 3.7 and higher.

simonw added a commit that referenced this issue Oct 18, 2022
@simonw
Copy link
Owner Author

simonw commented Oct 18, 2022

@simonw simonw closed this as completed Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant