Enhance log of VM skip delete (openshift#260)

jichenjc · pierreprinetti · commit 39b46a580a2b · 2024-04-22T14:29:42.000+02:00
I deleted 2 machines and one is gone.. this log didn't provide which is skipped.

I0315 07:01:55.409478       1 actuator.go:193] Skipped deleting a VM that is already deleted.
diff --git a/pkg/cloud/openstack/machine/actuator.go b/pkg/cloud/openstack/machine/actuator.go
@@ -187,7 +187,7 @@ func (oc *OpenstackClient) Delete(ctx context.Context, cluster *clusterv1.Cluste
 	}
 
 	if instance == nil {
-		klog.Infof("Skipped deleting a VM that is already deleted.\n")
+		klog.Infof("Skipped deleting %s that is already deleted.\n", machine.Name)
 		return nil
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -187,7 +187,7 @@ func (oc OpenstackClient) Delete(ctx context.Context, cluster clusterv1.Cluste`
`187`	`187`	`}`
`188`	`188`
`189`	`189`	`if instance == nil {`
`190`		`- klog.Infof("Skipped deleting a VM that is already deleted.\n")`
	`190`	`+ klog.Infof("Skipped deleting %s that is already deleted.\n", machine.Name)`
`191`	`191`	`return nil`
`192`	`192`	`}`
`193`	`193`