Skip to content

Commit c336916

Browse files
author
sroda
committed
Merge branch 'main' into metrics-instrumentation-tornado
* main: Codespell ci (open-telemetry#1237) aiohttp-client: Fix producing additional spans with each newly created ClientSession (open-telemetry#1246) Remove support for 3.6 (open-telemetry#853) Added the Licence and Manifest file Restore metrics in django (open-telemetry#1208) fix typo in example codes (open-telemetry#1240) boto3sqs: Make propagation compatible with other instrumentations and add 'messaging.url' span attribute (open-telemetry#1234) Release 1.12.0-0.33b0 (open-telemetry#1223) Fix Flask instrumentation doc link (open-telemetry#1216) Feature/metrics instrumentation urllib3 (open-telemetry#1198) Metric instrumentation asgi (open-telemetry#1197) Metrics instrumentation flask (open-telemetry#1186) Adding sqlalchemy native tags in sqlalchemy commenter (open-telemetry#1206) ci: fix docs workflow failure (open-telemetry#1211) Add psycopg2 native tags to sqlcommenter (open-telemetry#1203) SQLCommenter semicolon bug fix (open-telemetry#1200) Sync with sdk setup from setUpClass to setUp (open-telemetry#1193) # Conflicts: # CHANGELOG.md # instrumentation/opentelemetry-instrumentation-tornado/src/opentelemetry/instrumentation/tornado/__init__.py # instrumentation/opentelemetry-instrumentation-tornado/src/opentelemetry/instrumentation/tornado/client.py
2 parents 4d52bbb + 18e056b commit c336916

File tree

199 files changed

+4320
-972
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

199 files changed

+4320
-972
lines changed

.codespellrc

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
[codespell]
2+
# skipping auto generated folders
3+
skip = ./.tox,./.mypy_cache,./docs/_build,./target,*/LICENSE,./venv
4+
ignore-words-list = ot

.github/workflows/test.yml

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,31 +6,30 @@ on:
66
- 'release/*'
77
pull_request:
88
env:
9-
CORE_REPO_SHA: 05d251c5d6baefe2f084e7361cb144c4fa10da96
9+
CORE_REPO_SHA: b3b0ba3a47dbdd844b524c46db22a60549364071
1010

1111
jobs:
1212
build:
1313
env:
1414
# We use these variables to convert between tox and GHA version literals
15-
py36: 3.6
1615
py37: 3.7
1716
py38: 3.8
1817
py39: 3.9
1918
py310: "3.10"
20-
pypy3: pypy3
19+
pypy3: "pypy3.7"
2120
RUN_MATRIX_COMBINATION: ${{ matrix.python-version }}-${{ matrix.package }}-${{ matrix.os }}
2221
runs-on: ${{ matrix.os }}
2322
strategy:
2423
fail-fast: false # ensures the entire test matrix is run, even if one permutation fails
2524
matrix:
26-
python-version: [ py36, py37, py38, py39, py310, pypy3 ]
25+
python-version: [ py37, py38, py39, py310, pypy3 ]
2726
package: ["instrumentation", "distro", "exporter", "sdkextension", "propagator"]
2827
os: [ ubuntu-20.04 ]
2928
steps:
3029
- name: Checkout Contrib Repo @ SHA - ${{ github.sha }}
3130
uses: actions/checkout@v2
3231
- name: Set up Python ${{ env[matrix.python-version] }}
33-
uses: actions/setup-python@v2
32+
uses: actions/setup-python@v4
3433
with:
3534
python-version: ${{ env[matrix.python-version] }}
3635
- name: Install tox
@@ -42,7 +41,7 @@ jobs:
4241
path: |
4342
.tox
4443
~/.cache/pip
45-
key: v6-build-tox-cache-${{ env.RUN_MATRIX_COMBINATION }}-${{ hashFiles('tox.ini', 'gen-requirements.txt', 'dev-requirements.txt') }}
44+
key: v7-build-tox-cache-${{ env.RUN_MATRIX_COMBINATION }}-${{ hashFiles('tox.ini', 'gen-requirements.txt', 'dev-requirements.txt') }}
4645
- name: run tox
4746
run: tox -f ${{ matrix.python-version }}-${{ matrix.package }} -- --benchmark-json=${{ env.RUN_MATRIX_COMBINATION }}-benchmark.json
4847
# - name: Find and merge ${{ matrix.package }} benchmarks
@@ -96,7 +95,7 @@ jobs:
9695
strategy:
9796
fail-fast: false
9897
matrix:
99-
tox-environment: [ "docker-tests", "lint", "docs", "generate" ]
98+
tox-environment: [ "docker-tests", "spellcheck", "lint", "docs", "generate" ]
10099
name: ${{ matrix.tox-environment }}
101100
runs-on: ubuntu-20.04
102101
steps:
@@ -118,7 +117,7 @@ jobs:
118117
path: |
119118
.tox
120119
~/.cache/pip
121-
key: v6-misc-tox-cache-${{ matrix.tox-environment }}-${{ hashFiles('tox.ini', 'dev-requirements.txt', 'gen-requirements.txt', 'docs-requirements.txt') }}
120+
key: v7-misc-tox-cache-${{ matrix.tox-environment }}-${{ hashFiles('tox.ini', 'dev-requirements.txt', 'gen-requirements.txt', 'docs-requirements.txt') }}
122121
- name: run tox
123122
run: tox -e ${{ matrix.tox-environment }}
124123
- name: Ensure generated code is up to date

CHANGELOG.md

Lines changed: 28 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,37 @@ All notable changes to this project will be documented in this file.
55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

8-
## [Unreleased](https://github.com/open-telemetry/opentelemetry-python/compare/v1.12.0rc2-0.32b0...HEAD)
8+
## [Unreleased]
9+
10+
### Fixed
11+
12+
- `opentelemetry-instrumentation-boto3sqs` Make propagation compatible with other SQS instrumentations, add 'messaging.url' span attribute, and fix missing package dependencies.
13+
([#1234](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1234))
14+
- restoring metrics in django framework
15+
([#1208](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1208))
16+
- `opentelemetry-instrumentation-aiohttp-client` Fix producing additional spans with each newly created ClientSession
17+
- ([#1246](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1246))
18+
19+
## [1.12.0-0.33b0](https://github.com/open-telemetry/opentelemetry-python/releases/tag/v1.12.0-0.33b0) - 2022-08-08
20+
921
- Adding multiple db connections support for django-instrumentation's sqlcommenter
1022
([#1187](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1187))
23+
- SQLCommenter semicolon bug fix
24+
([#1200](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1200/files))
25+
- Adding sqlalchemy native tags in sqlalchemy commenter
26+
([#1206](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1206))
27+
- Add psycopg2 native tags to sqlcommenter
28+
([#1203](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1203))
1129

1230
### Added
1331
- `opentelemetry-instrumentation-redis` add support to instrument RedisCluster clients
1432
([#1177](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1177))
1533
- `opentelemetry-instrumentation-sqlalchemy` Added span for the connection phase ([#1133](https://github.com/open-telemetry/opentelemetry-python-contrib/issues/1133))
16-
- `opentelemetry-instrumentation-tornado` Add metric instrumentation
34+
- Add metric instrumentation in asgi
35+
([#1197](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1197))
36+
- Add metric instumentation for flask
37+
([#1186](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1186))
38+
- Add metric instrumentation for tornado
1739
([#1252](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1252))
1840

1941
## [1.12.0rc2-0.32b0](https://github.com/open-telemetry/opentelemetry-python/releases/tag/v1.12.0rc2-0.32b0) - 2022-07-01
@@ -51,6 +73,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
5173
([#1127](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1127))
5274
- Add metric instrumentation for WSGI
5375
([#1128](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1128))
76+
- Add metric instrumentation for Urllib3
77+
([#1198](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1198))
5478
- `opentelemetry-instrumentation-aio-pika` added RabbitMQ aio-pika module instrumentation.
5579
([#1095](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1095))
5680
- `opentelemetry-instrumentation-requests` Restoring metrics in requests
@@ -418,7 +442,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
418442
([#567](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/567))
419443
- `opentelemetry-instrumentation-grpc` Respect the suppress instrumentation in gRPC client instrumentor
420444
([#559](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/559))
421-
- `opentelemetry-instrumentation-grpc` Fixed asynchonous unary call traces
445+
- `opentelemetry-instrumentation-grpc` Fixed asynchronous unary call traces
422446
([#536](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/536))
423447
- `opentelemetry-sdk-extension-aws` Update AWS entry points to match spec
424448
([#566](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/566))
@@ -714,7 +738,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
714738
([#182](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/182))
715739
- `opentelemetry-instrumentation-botocore` Botocore SpanKind as CLIENT and modify existing traced attributes
716740
([#150](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/150))
717-
- `opentelemetry-instrumentation-dbapi` Update dbapi and its dependant instrumentations to follow semantic conventions
741+
- `opentelemetry-instrumentation-dbapi` Update dbapi and its dependent instrumentations to follow semantic conventions
718742
([#195](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/195))
719743
- `opentelemetry-instrumentation-dbapi` Stop capturing query parameters by default
720744
([#156](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/156))

CONTRIBUTING.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ You can run:
4444
- `tox -e py37-test-flask` to e.g. run the Flask tests under a specific
4545
Python version
4646
- `tox -e lint` to run lint checks on all code
47+
- `tox -e spellcheck` to run spell check on the code
4748

4849
See
4950
[`tox.ini`](https://github.com/open-telemetry/opentelemetry-python-contrib/blob/main/tox.ini)
@@ -172,7 +173,7 @@ The continuation integration overrides that environment variable with as per the
172173

173174
* docstrings should adhere to the [Google Python Style
174175
Guide](http://google.github.io/styleguide/pyguide.html#38-comments-and-docstrings)
175-
as specified with the [napolean
176+
as specified with the [napoleon
176177
extension](http://www.sphinx-doc.org/en/master/usage/extensions/napoleon.html#google-vs-numpy)
177178
extension in [Sphinx](http://www.sphinx-doc.org/en/master/index.html).
178179

@@ -194,7 +195,7 @@ Below is a checklist of things to be mindful of when implementing a new instrume
194195
- https://github.com/open-telemetry/opentelemetry-python-contrib/issues/344 for more context
195196
- `exclude_urls` functionality
196197
- ex. https://github.com/open-telemetry/opentelemetry-python-contrib/blob/0fcb60d2ad139f78a52edd85b1cc4e32f2e962d0/instrumentation/opentelemetry-instrumentation-flask/src/opentelemetry/instrumentation/flask/__init__.py#L91
197-
- `url_filter` functonality
198+
- `url_filter` functionality
198199
- ex. https://github.com/open-telemetry/opentelemetry-python-contrib/blob/0fcb60d2ad139f78a52edd85b1cc4e32f2e962d0/instrumentation/opentelemetry-instrumentation-aiohttp-client/src/opentelemetry/instrumentation/aiohttp_client/__init__.py#L235
199200
- `is_recording()` optimization on non-sampled spans
200201
- ex. https://github.com/open-telemetry/opentelemetry-python-contrib/blob/main/instrumentation/opentelemetry-instrumentation-requests/src/opentelemetry/instrumentation/requests/__init__.py#L133
@@ -204,5 +205,5 @@ Below is a checklist of things to be mindful of when implementing a new instrume
204205

205206
## Expectations from contributors
206207

207-
OpenTelemetry is an open source community, and as such, greatly encourages contributions from anyone interested in the project. With that being said, there is a certain level of expectation from contributors even after a pull request is merged, specifically pertaining to instrumentations. The OpenTelemetry Python community expects contributors to maintain a level of support and interest in the instrumentations they contribute. This is to ensure that the instrumentation does not become stale and still functions the way the original contributor intended. Some instrumentations also pertain to libraries that the current memebers of the community are not so familiar with, so it is necessary to rely on the expertise of the original contributing parties.
208+
OpenTelemetry is an open source community, and as such, greatly encourages contributions from anyone interested in the project. With that being said, there is a certain level of expectation from contributors even after a pull request is merged, specifically pertaining to instrumentations. The OpenTelemetry Python community expects contributors to maintain a level of support and interest in the instrumentations they contribute. This is to ensure that the instrumentation does not become stale and still functions the way the original contributor intended. Some instrumentations also pertain to libraries that the current members of the community are not so familiar with, so it is necessary to rely on the expertise of the original contributing parties.
208209

_template/setup.cfg

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,20 +34,19 @@ classifiers =
3434
License :: OSI Approved :: Apache Software License
3535
Programming Language :: Python
3636
Programming Language :: Python :: 3
37-
Programming Language :: Python :: 3.6
3837
Programming Language :: Python :: 3.7
3938
Programming Language :: Python :: 3.8
4039
Programming Language :: Python :: 3.9
4140
Programming Language :: Python :: 3.10
4241

4342
[options]
44-
python_requires = >=3.6
43+
python_requires = >=3.7
4544
package_dir=
4645
=src
4746
packages=find_namespace:
4847

4948
install_requires =
50-
opentelemetry-api ~= 1.3
49+
opentelemetry-api ~= 1.12
5150

5251
[options.extras_require]
5352
test =

_template/version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,4 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
__version__ = "0.32b0"
15+
__version__ = "0.33b0"

dev-requirements.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,3 +15,4 @@ grpcio-tools==1.29.0
1515
mypy-protobuf>=1.23
1616
protobuf~=3.13
1717
markupsafe==2.0.1
18+
codespell==2.1.0

docs-requirements.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,4 +41,6 @@ httpx>=0.18.0
4141

4242
# indirect dependency pins
4343
markupsafe==2.0.1
44-
itsdangerous==2.0.1
44+
itsdangerous==2.0.1
45+
46+
docutils==0.16

eachdist.ini

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ sortfirst=
1616
ext/*
1717

1818
[stable]
19-
version=1.12.0rc2
19+
version=1.12.0
2020

2121
packages=
2222
opentelemetry-sdk
@@ -34,7 +34,7 @@ packages=
3434
opentelemetry-api
3535

3636
[prerelease]
37-
version=0.32b0
37+
version=0.33b0
3838

3939
packages=
4040
all

exporter/opentelemetry-exporter-datadog/setup.cfg

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,21 +28,20 @@ classifiers =
2828
License :: OSI Approved :: Apache Software License
2929
Programming Language :: Python
3030
Programming Language :: Python :: 3
31-
Programming Language :: Python :: 3.6
3231
Programming Language :: Python :: 3.7
3332
Programming Language :: Python :: 3.8
3433
Programming Language :: Python :: 3.9
3534
Programming Language :: Python :: 3.10
3635

3736
[options]
38-
python_requires = >=3.6
37+
python_requires = >=3.7
3938
package_dir=
4039
=src
4140
packages=find_namespace:
4241
install_requires =
4342
ddtrace>=0.34.0,<0.47.0
44-
opentelemetry-api ~= 1.3
45-
opentelemetry-sdk ~= 1.3
43+
opentelemetry-api ~= 1.12
44+
opentelemetry-sdk ~= 1.12
4645
opentelemetry-semantic-conventions == 0.30b0
4746

4847
[options.packages.find]

0 commit comments

Comments
 (0)