Add support for openssl3 KDF methods #1426
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baloo
force-pushed
the
baloo/openssl-300/kdf
branch
6 times, most recently
from
b42fec4 to
0b7e667
Compare
Signed-off-by: Arthur Gautier <[email protected]>
Signed-off-by: Arthur Gautier <[email protected]>
Signed-off-by: Arthur Gautier <[email protected]>
Signed-off-by: Arthur Gautier <[email protected]>
Signed-off-by: Arthur Gautier <[email protected]>
Signed-off-by: Arthur Gautier <[email protected]>
From discussion on openssl/openssl#14551 it sounds like set_params is going to be deprecated. Signed-off-by: Arthur Gautier <[email protected]>
Signed-off-by: Arthur Gautier <[email protected]>
baloo
force-pushed
the
baloo/openssl-300/kdf
branch
from
f826776 to
41995aa
Compare
|
Why not send PR based on #1264 |
it's based on openssl-300 and targets it, so I'm not sure what you're referring to. |
|
@sfackler, you closed this without comment--are you open to adding support for this KDF functionality? |
|
@jstarks it automatically closed because the target branch has been removed. I did not have time to re-target and make the adjustments necessary. feel free to take over. |
|
Ah, I see. OK, I may follow up here later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to add support for the KDF api openssl3 brings.
The current implementation works, but only supports the KDF I need. I'm sharing early see if you'd have any opinions about the proposed API before I add support for other KDFs.
From my understanding, KDF only works with
OSSL_PARAMSwhich are not the easiest thing to use from rust. This is an attempt, but I'm not necessarily convinced.Please don't mind the extra OAEP label commit, It's merged in master, it's only here because it's easier for me to develop and test the whole api. I'll drop the commit eventually.