Skip to content

Sync changes from mozilla-central #3506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 14, 2019
Merged

Sync changes from mozilla-central #3506

merged 3 commits into from
Jan 14, 2019

Conversation

moz-gfx
Copy link

@moz-gfx moz-gfx commented Jan 14, 2019 •
edited by larsbergstrom
Loading

This change is Reviewable

@moz-gfx
Copy link
Author

moz-gfx commented Jan 14, 2019

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 8daf5ed has been approved by moz-gfx

bors-servo pushed a commit that referenced this pull request Jan 14, 2019
Auto merge of #3506 - moz-gfx:__wrlastsync, r=moz-gfx
fdffba8 
Sync changes from mozilla-central
@bors-servo
Copy link
Contributor

⌛ Testing commit 8daf5ed with merge fdffba8...

@bors-servo
Copy link
Contributor

☀️ Test successful - status-appveyor, status-taskcluster
Approved by: moz-gfx
Pushing fdffba8 to master...

@bors-servo bors-servo merged commit 8daf5ed into servo:master Jan 14, 2019
@staktrace
Copy link
Contributor

@lsalzman I think these patches might have made reftests/text/shadow.yaml == reftests/text/shadow-ref.yaml intermittent on macOS. The test passed on the merge commit bors made here but failed on the tests that ran as part of the PR branch here and now stuff landing on top of this are also hitting failures in #3507. Unfortunately we are not running macOS wrench reftests on treeherder (it was deemed nonblocking) so this didn't get caught earlier. If you can investigate that would be good.

@staktrace
Copy link
Contributor

Seems to be almost permafail, so even just changing the reftest to match would probably be good enough for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@moz-gfx @bors-servo @staktrace @lsalzman