Insert the shader name in the source. #1821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes life easier when looking at apitrace recordings.
kvark
reviewed
Oct 6, 2017
| @@ -183,6 +183,11 @@ pub fn build_shader_strings( | |||
| vs_source.push_str(gl_version_string); | |||
| fs_source.push_str(gl_version_string); | |||
|
|
|||
| // Insert the shader name to make debugging easier. | |||
| let name_string = format!("// {}\n", base_filename); | |||
There was a problem hiding this comment.
perhaps, it would make sense to do in debug only?
There was a problem hiding this comment.
I use apitrace with release builds too and I don't think this adds any noticeable overhead so I lean towards leaving it in release builds as well unless you feel strongly about it.
|
Okey |
|
📌 Commit 6bae0eb has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Oct 6, 2017
Insert the shader name in the source. This makes life easier when looking at apitrace recordings. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1821) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes life easier when looking at apitrace recordings.
This change is